Enums #62
Open
Enums #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2021
david942j
reviewed
May 7, 2021
lib/elftools/enums.rb
Outdated
| attr_reader :values | ||
| end | ||
|
|
||
| def initialize(attrs = 0) |
There was a problem hiding this comment.
I'm confused about the name - shouldn't "attrs" be "value"?
There was a problem hiding this comment.
add description about the parameter, seems it can be an integer or a symbol
| class Relocation32 < Enum | ||
| exclusive true | ||
| enum_attr :none, 0 | ||
| enum_attr :"32", 1 |
There was a problem hiding this comment.
I don't like these integer names but.. sigh
Allow usages: ``` Bind::LOCAL Bind.LOCAL Bind[:local] ``` Allow comparisons: ``` b == 0 b == 'local' b == :local b == Bind::LOCAL ```
david942j
requested changes
May 8, 2021
| end | ||
|
|
||
| class << self | ||
| attr_reader :values |
| class << self | ||
| attr_reader :values | ||
|
|
||
| def val(value) |
| def val(value) | ||
| key = if value.is_a? self.class | ||
| value.to_i | ||
| elsif values.keys.include?(value) |
There was a problem hiding this comment.
keys.include? can be replaced with "key?"
|
|
||
| def inspect | ||
| v = self.class.values[@value] | ||
| v ? "#{self.class.name}.#{v.upcase}" : @value |
There was a problem hiding this comment.
unsure whether it matters - shouldn't "@value" be "@value.inspect"?
|
Any update here :) ? |
|
yes? |
|
Sorry, will do, got small setback and had little time
…On Sat, Jul 24, 2021, 16:37 david942j ***@***.***> wrote:
yes?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWONCR3HU6UTDXWRFZCNQ3TZLFZ3ANCNFSM44FXJORQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not consider this part of code perfect, yet this is what I came up with to manage elf types more easily.
I think constants should be accessed with Class::CONSTANT, eg.
Visibility::NONE, yet these enums currently work only withVisibility.NONE. I did not fix it, I was short on time. I also don't see clear solution.What I wanted from these enums:
puts symbol.st_visto printNoneinstead of ... 42 or whatever.symbol.st_vis + 2to be 44 (or whatever) instead of "None2", currently may require casting with.to_isymbol.st_vis = :none, dunno if worksPart of #52