ReadThrough DB constraints #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each readthrough should represent a unique instance of reading a book, and so it should have a single status that represents that status of that readthrough. This will be used to place the book on the appropriate "shelves", and should allow for there to be a single active readthrough if a book is in progress. That maeks the `is_active` field unnecessary. Since the status of the readthrough is unambiguous, defining "finished date" and "stopped date" separately is no longer necessary. I've sketched out some database constraints but haven't implemented them yet, because the conflicts might get gnarly and let's take this one step at a time. The migration logic is complex, so this is an untested draft and I'll write unit tests for it in a subsequent commit.
Good news: they run now
Conflicts: bookwyrm/models/readthrough.py Also changed dependencies of migration "0151_auto_20220703_1842": 0150_readthrough_stopped_date -> 0184_auto_20231106_0421.
dato
force-pushed
the
readthrough_constraints
branch
from
e0ff246 to
b1ce562
Compare
dato
force-pushed
the
main
branch
2 times, most recently
from
b9cc8cd to
7f773b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_statusin ReadThrough