feat: Resumable Full Load In Mongodb #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikash390
changed the title
hash-data
changed the title
shubham19may
requested changes
Feb 12, 2025
drivers/mongodb/internal/backfill.go
Outdated
Comment on lines
57
to
68
| if end.After(last) { | ||
| boundry = types.Chunk{ | ||
| Min: generateMinObjectID(start), | ||
| Max: "", | ||
| } | ||
| logger.Info("scheduling last full load chunk query!") | ||
| } else { | ||
| boundry = types.Chunk{ | ||
| Min: generateMinObjectID(start), | ||
| Max: generateMinObjectID(end), | ||
| } | ||
| } |
There was a problem hiding this comment.
can be simplified. Created boundry struct at the end.
drivers/mongodb/internal/backfill.go
Outdated
| } | ||
| } | ||
| chunks = append(chunks, boundry) | ||
| chunk := types.Chunk{ |
There was a problem hiding this comment.
why are you again creating an chunk var?
drivers/mongodb/internal/backfill.go
Outdated
| stream.AppendChunksToStreamState(chunk) | ||
| start = end | ||
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
what if node crashes here, where are we storing the chunks into state file?
types/state.go
Outdated
| @@ -81,36 +81,69 @@ func (s *State) MarshalJSON() ([]byte, error) { | |||
| return json.Marshal(p) | |||
| } | |||
|
|
|||
| // DualSyncMap struct to hold Cursor and Chunks | |||
There was a problem hiding this comment.
change comment. Please self-review PR line by line.
types/stream_configured.go
Outdated
| }) | ||
| return chunks | ||
| } | ||
| func (s *ConfiguredStream) UpdateChunkStatusInStreamState(chunkID string, newStatus string) { |
There was a problem hiding this comment.
we need to persist to disk here. as OOM can occur at any place.
…c/olake into feat/state-controller
|
Will add defaultFlag for partitioning path in this PR |
…at/state-controller
…at/state-controller
logger/logger.go
Outdated
| @@ -180,7 +124,8 @@ func FileLogger(content any, filePath string, fileName, fileExtension string) er | |||
|
|
|||
| func Init() { | |||
| // Configure lumberjack for log rotation | |||
| timestamp := fmt.Sprintf("%d-%d-%d_%d-%d-%d", time.Now().Year(), time.Now().Month(), time.Now().Day(), time.Now().Hour(), time.Now().Minute(), time.Now().Second()) | |||
| timeStamp := time.Now().UTC() | |||
There was a problem hiding this comment.
name it something else. one can not have same name but camel case
shubham19may
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added logging for failed chunks in the terminal and implemented handling to retry processing them efficiently.
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):