Merge pull request #21 from datashaman/develop

More small fixes

.gitignore

@@ -10,4 +10,5 @@
 /.phpunit.result.cache
 /report/
 /vendor/
+/vendor-bin/
 /.vscode/

Makefile

@@ -20,22 +20,12 @@ docs-functions:
 phpcheck:
 	@phpcheck
 
-phpcheck-coverage-html:
+phpcheck-coverage:
 	sudo phpenmod xdebug
 	@phpcheck --coverage-html report/phpcheck-coverage
 	sudo phpdismod xdebug
 	@xdg-open report/phpcheck-coverage/index.html
 
-phpcheck-coverage-console:
-	sudo phpenmod xdebug
-	@phpcheck --coverage-text
-	sudo phpdismod xdebug
-
-phpcheck-coverage-text:
-	sudo phpenmod xdebug
-	@phpcheck --coverage-text report/phpcheck-coverage.txt
-	sudo phpdismod xdebug
-
 phpcheck-log-junit:
 	@phpcheck --log-junit build/phpcheck.xml
 

checks/GeneratorCheck.php

@@ -35,7 +35,7 @@ function ($interval) use ($ord) {
 
     public function checkStrings(string $string): bool
     {
-        return \mb_strlen($string) < 100;
+        return \mb_strlen($string) <= 30;
     }
 
     /**

composer.json

@@ -38,6 +38,7 @@
         "webmozart/assert": "^1.4"
     },
     "require-dev": {
+        "bamarni/composer-bin-plugin": "^1.3",
         "cache/redis-adapter": "^1.0",
         "friendsofphp/php-cs-fixer": "^2.14",
         "knplabs/github-api": "^2.11",
@@ -47,6 +48,9 @@
         "phpunit/phpunit": "^8.1",
         "symfony/templating": "^4.2"
     },
+    "suggest": {
+        "ext-simplexml": "Enables JUnit XML report"
+    },
     "config": {
         "platform": {
             "php": "7.2.0"
@@ -72,5 +76,10 @@
             "Datashaman\\PHPCheck\\Checks\\": "checks/",
             "Datashaman\\PHPCheck\\Tests\\": "tests/"
         }
+    },
+    "scripts": {
+        "bin": "echo 'bin not installed'",
+        "post-install-cmd": ["@composer bin all install --ansi"],
+        "post-update-cmd": ["@composer bin all update --ansi"]
     }
 }

src/Args.php

@@ -1,19 +1,37 @@
-<?php
-
+<?php declare(strict_types=1);
+/*
+ * This file is part of the phpcheck package.
+ *
+ * ©Marlin Forbes <marlinf@datashaman.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
 namespace Datashaman\PHPCheck;
 
 class Args
 {
     public $bootstrap;
+
     public $coverageHtml = false;
+
     public $coverageText = false;
+
     public $filter;
+
     public $logJunit = false;
+
     public $logText = false;
+
     public $maxSuccess = Runner::MAX_SUCCESS;
+
     public $noAnsi;
+
     public $noDefects;
+
     public $path;
+
     public $output;
+
     public $subject;
 }

src/CheckCommand.php

@@ -94,17 +94,17 @@ protected function execute(InputInterface $input, OutputInterface $output): ?int
     {
         $args = new Args();
 
-        $args->bootstrap = $input->getOption('bootstrap');
+        $args->bootstrap    = $input->getOption('bootstrap');
         $args->coverageHtml = $input->getOption('coverage-html');
         $args->coverageText = $input->getOption('coverage-text');
-        $args->filter = $input->getOption('filter');
-        $args->logJunit = $input->getOption('log-junit');
-        $args->logText = $input->getOption('log-text');
-        $args->maxSuccess = $input->getOption('max-success');
-        $args->noAnsi = $input->getOption('no-ansi');
-        $args->noDefects = $input->getOption('no-defects');
-        $args->output = $output;
-        $args->path = $input->getArgument('path');
+        $args->filter       = $input->getOption('filter');
+        $args->logJunit     = $input->getOption('log-junit');
+        $args->logText      = $input->getOption('log-text');
+        $args->maxSuccess   = $input->getOption('max-success');
+        $args->noAnsi       = $input->getOption('no-ansi');
+        $args->noDefects    = $input->getOption('no-defects');
+        $args->output       = $output;
+        $args->path         = $input->getArgument('path');
 
         $result = app('runner')->execute($args);
 

src/Coverage/TextCoverage.php

@@ -9,7 +9,6 @@
  */
 namespace Datashaman\PHPCheck\Coverage;
 
-use function Datashaman\PHPCheck\app;
 use SebastianBergmann\CodeCoverage\Report\Text;
 
 /**
@@ -18,12 +17,9 @@
 class TextCoverage extends Coverage
 {
     private $_output;
+
     private $_noAnsi;
 
-    /**
-     * @param null|string $output
-     * @param null|bool $noAnsi
-     */
     public function __construct(
         string $output = null,
         bool $noAnsi = null

src/Events/EndEvent.php

@@ -37,7 +37,7 @@ public function __construct(
     ) {
         parent::__construct();
         $this->function = $function;
-        $this->tags   = $tags;
-        $this->status = $status;
+        $this->tags     = $tags;
+        $this->status   = $status;
     }
 }

src/Events/ResultEvent.php

@@ -49,8 +49,8 @@ public function __construct(
     ) {
         parent::__construct();
         $this->function = $function;
-        $this->tags   = $tags;
-        $this->args   = $args;
-        $this->cause  = $cause;
+        $this->tags     = $tags;
+        $this->args     = $args;
+        $this->cause    = $cause;
     }
 }

src/Events/StartEvent.php

@@ -31,6 +31,6 @@ public function __construct(
     ) {
         parent::__construct();
         $this->function = $function;
-        $this->tags   = $tags;
+        $this->tags     = $tags;
     }
 }

src/Random.php

@@ -17,7 +17,7 @@ public function random($min = 0, $max = null)
     {
         do {
             $value = parent::random($min, $max);
-        } while (!is_int($value));
+        } while (!\is_int($value));
 
         return $value;
     }