Code

Pester migration - Second batch#9530

Code

Merged

potatoqualitee merged 29 commits intodevelopmentdataplat/dbatools:developmentfrom secondbatchdataplat/dbatools:secondbatchCopy head branch name to clipboardOct 26, 2024

+1,866-1,049

Commits

Commits on Oct 25, 2024

• revert to re-fix

  potatoqualitee

  committed
  8b93039

  Copy full SHA for 8b93039

• update instructions to be a little shorter

  potatoqualitee

  committed
  c4bcd7b

  Copy full SHA for c4bcd7b

• follow slightly new format

  potatoqualitee

  committed
  43ce0a5

  Copy full SHA for 43ce0a5

• uncomment skipper

  potatoqualitee

  committed
  7c61359

  Copy full SHA for 7c61359

• Update tests

  potatoqualitee

  committed
  69b7dc3

  Copy full SHA for 69b7dc3

• fix param checker - we will be checking for whatif and confirm

  potatoqualitee

  committed
  fca2562

  Copy full SHA for fca2562

• shorten var, fix test

  potatoqualitee

  committed
  b5be793

  Copy full SHA for b5be793

• lez see

  potatoqualitee

  committed
  a09937f

  Copy full SHA for a09937f

• move param test

  potatoqualitee

  committed
  664904e

  Copy full SHA for 664904e

• fix failures

  potatoqualitee

  committed
  a6958ca

  Copy full SHA for a6958ca

• one change

  potatoqualitee

  committed
  eaabf51

  Copy full SHA for eaabf51

• ReorgParams

  Show description for ebe6660
  potatoqualitee

  committed
  ebe6660

  Copy full SHA for ebe6660

• i dunno

  potatoqualitee

  committed
  8e085ac

  Copy full SHA for 8e085ac

• maybe

  potatoqualitee

  committed
  a92e29f

  Copy full SHA for a92e29f

Commits on Oct 26, 2024

• trying to get it to work locally

  potatoqualitee

  committed
  9ac5114

  Copy full SHA for 9ac5114

• who knows, im about to skip it

  potatoqualitee

  committed
  e48f744

  Copy full SHA for e48f744

• add defaults

  potatoqualitee

  committed
  3c085e6

  Copy full SHA for 3c085e6

• move things

  potatoqualitee

  committed
  4e85fba

  Copy full SHA for 4e85fba

• add defaults

  potatoqualitee

  committed
  b3f5560

  Copy full SHA for b3f5560

• move it back to top, expected is needed for the foreach

  potatoqualitee

  committed
  03d1cc6

  Copy full SHA for 03d1cc6

• aider cleanup

  potatoqualitee

  committed
  2e02db1

  Copy full SHA for 2e02db1

• fix test

  Show description for 244e129
  potatoqualitee

  committed
  244e129

  Copy full SHA for 244e129

• it should just be skipped, it shouldnt try to bring over the notification too

  potatoqualitee

  committed
  720dc05

  Copy full SHA for 720dc05

• that test got all kinds of messed up

  potatoqualitee

  committed
  f23f7c6

  Copy full SHA for f23f7c6

• oops, forgot to actually run the code (do Add-DbaPfDataCollectorCounter)

  potatoqualitee

  committed
  2339c66

  Copy full SHA for 2339c66

• fix scope

  potatoqualitee

  committed
  e26b8b7

  Copy full SHA for e26b8b7

• fix scope

  potatoqualitee

  committed
  881bfc2

  Copy full SHA for 881bfc2

• fix prompt

  potatoqualitee

  committed
  ffddf03

  Copy full SHA for ffddf03

• turns out the scoping was right all along

  potatoqualitee

  committed
  addd41f

  Copy full SHA for addd41f