Copy-DbaCredential: Fix for credentials with square brackets in it's …

…name - Issue #9242 (#9243) Co-authored-by: Ivan Vacho <ivan.vacho@ccs.cz>
dataplat · Mar 7, 2024 · e72e1a4 · e72e1a4
1 parent 54c8d25
commit e72e1a4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/public/Copy-DbaCredential.ps1 b/public/Copy-DbaCredential.ps1
@@ -202,7 +202,7 @@ function Copy-DbaCredential {
                 Write-Message -Level Verbose -Message "Attempting to migrate $credentialName"
                 try {
                     $decryptedCred = $decryptedCredentials | Where-Object { $_.Name -eq $credentialName }
-                    $sqlcredentialName = $credentialName.Replace("'", "''")
+                    $sqlcredentialName = $decryptedCred.Quotename
                     $identity = $decryptedCred.Identity.Replace("'", "''")
                     $password = $decryptedCred.Password.Replace("'", "''")
 
@@ -217,7 +217,7 @@ function Copy-DbaCredential {
                     }
 
                     if ($Pscmdlet.ShouldProcess($destinstance, "Copying $identity ($credentialName)")) {
-                        $destServer.Query("CREATE CREDENTIAL [$sqlcredentialName] WITH IDENTITY = N'$identity', SECRET = N'$password' $cryptoSQL")
+                        $destServer.Query("CREATE CREDENTIAL $sqlcredentialName WITH IDENTITY = N'$identity', SECRET = N'$password' $cryptoSQL")
                         $destServer.Credentials.Refresh()
                         Write-Message -Level Verbose -Message "$credentialName successfully copied"
                         $copyCredentialStatus.Status = "Successful"