Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSRF definition #12

Open
mesteranna opened this issue Feb 4, 2025 · 3 comments
Open

CSRF definition #12

mesteranna opened this issue Feb 4, 2025 · 3 comments
Assignees
@antaldaniel
Labels
documentation Improvements or additions to documentation

Comments

@mesteranna
Copy link
Contributor

left_join_column.R is missing the csrf definition.

get_csrf.R definition: Get a Cross-Site Request Forgery (CSRF) response.

It is still not clear to me what CSRF means. Looked up the definition: ("Cross-Site Request Forgery (CSRF) is an attack that forces an end user to execute unwanted actions on a web application in which they’re currently authenticated. ")
Our get_csrf_token is giving protection from this attack?
@antaldaniel antaldaniel self-assigned this Feb 14, 2025
@antaldaniel antaldaniel added the documentation Improvements or additions to documentation label Feb 14, 2025
@antaldaniel
Copy link
Contributor

@mesteranna Let me know if version 0.1.1012 solves thie issue (see new description)?

@mesteranna
Copy link
Contributor Author

mesteranna commented Feb 14, 2025 •
edited
Loading

left_join_column.R is still missing the csrf definition in the Arguments. The other one is solved, I find the explanation in get_csrf.R satisfactory.

@antaldaniel
Copy link
Contributor

Excellent issue, now fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antaldaniel antaldaniel

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antaldaniel @mesteranna