Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liq 2.0 hls #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Liq 2.0 hls #26

wants to merge 2 commits into from

Conversation

mcfiredrill
Copy link
Member

No description provided.

@mcfiredrill mcfiredrill changed the base branch from main to liq-2.0 February 6, 2022 23:39
video_source = fallback(id="video_fallback",track_sensitive=false,
[!live_video,
mux_audio(drop_audio(!vj_video), audio=source),
mksafe(mux_audio(single_video, audio=source))])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error 10: A source cannot belong to two clocks (mux_audio_1.child[],
mux_audio_0.child[]).
The command '/bin/sh -c eval $(opam env) && liquidsoap --check radio.liq' returned a non-zero code: 1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that the muxing operator wants control over the sources being muxed so make sure that it can pull data from both sources at the rate that's needed to synchronize audio and video content.

The buffer operator should be available to decorelate this so you can pass the same source into two different muxers. Something like this:

video_source = fallback(id="video_fallback",track_sensitive=false,
                        [!live_video,
                         mux_audio(drop_audio(!vj_video), audio=buffer(source)),
                         mksafe(mux_audio(single_video, audio=buffer(source)))])

This operator is in need of some love so let us know if you have any issue with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @toots ! This seems to compile.
So buffer will create a new clock for each muxer I assume?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Base automatically changed from liq-2.0 to main March 12, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants