Indexer: Improve perf by deferring index DB commit #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're writing to a local sqlite, we're not worried about losing connection to a remote DB and losing consistency, so we can defer the comit until the end.
|
My editor removed some trailing whitespace too. |
|
@martin-kokos thanks, I considered to replace sqlite with duckdb to speedup analytics after data processing. |
|
That's a separate topic, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're writing to a local sqlite, we're not worried about losing connection to a remote DB and losing consistency, so we can defer the commit until the end.
This speeds up indexing by about 30x.