Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raster and rgdal eliminated. #92

Merged
merged 4 commits into from
Nov 23, 2024
Merged

raster and rgdal eliminated. #92

merged 4 commits into from
Nov 23, 2024

Conversation

jonjab
Copy link
Contributor

@jonjab jonjab commented Nov 21, 2024

Closes #88

I updated scripts and calls to libraries in each episode to eliminate raster and rgdal.

This lesson also has a code directory, inside of which is a lot of dead and defunct code that reads as leftover from the development of the lesson. I edited it enough so that the repo builds in workbench, but it might be a good idea to get rid of that entire /code/ directory.

Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks so much @jonjab, I really appreciate you taking the time to work on this.

I will leave it open for a few more days, in case any of the lesson Maintainers also want to take a look. I will come back and merge next week if not.

@tobyhodges
Copy link
Member

Ah, looks like maybe the code/R/dc-spatio-temporal-intro/07-spatial-resolution-extent.R file still needs to have raster and rgdal removed?

I think we will have to update the renv.lock file too, to remove the packages as dependencies, before this will build. I can take care of that, if needed.

@jonjab
Copy link
Contributor Author

jonjab commented Nov 22, 2024

I don't know anything about how to do the renv.lock file,
but I did take care of ep7.r in my fork.

@tobyhodges
Copy link
Member

Merging this now, so that I can take care of the lockfile more easily

@tobyhodges tobyhodges merged commit 6a52fa5 into datacarpentry:main Nov 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace rgdal and rgeos with equivalent calls from sf or terra
2 participants