Let WorkflowLinter.refresh_report lint jobs from JobsCrawler
#3732
+39
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
step/assessment
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
❌ 84/85 passed, 1 failed, 7 skipped, 54m1s total ❌ test_running_real_assessment_job: AssertionError: assert 'UNKNOWN' != 'UNKNOWN' (15m4.057s)Running from acceptance #8364 |
4 tasks
FastLee
requested changes
Feb 21, 2025
|
|
||
| def refresh_report(self, sql_backend: SqlBackend, inventory_database: str) -> None: | ||
| tasks = [] | ||
| items_listed = 0 | ||
| for job in self._ws.jobs.list(): | ||
| if self._include_job_ids is not None and job.job_id not in self._include_job_ids: |
There was a problem hiding this comment.
Where do we replicate the filtering capability with the Job Crawler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Let
WorkflowLinter.refresh_reportlint jobs fromJobsCrawlerso that we only lint what is within scopeLinked issues
Resolves #3662
Progresses #3722
Functionality
assessmentTests