Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation process for Serverless #150

Merged
merged 28 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
12b9e16
disable integration tests on forks
mwojtyczka Feb 4, 2025
c9424ba
updated databricks cli requirement
mwojtyczka Feb 4, 2025
973b809
added comments
mwojtyczka Feb 4, 2025
f18f32c
updated docs
mwojtyczka Feb 5, 2025
0323235
updated docs
mwojtyczka Feb 5, 2025
55b61a6
added code-cov
mwojtyczka Feb 5, 2025
601fb84
added code-cov
mwojtyczka Feb 5, 2025
d261a2b
test
mwojtyczka Feb 5, 2025
e94e520
revert changes
mwojtyczka Feb 5, 2025
3786553
revert changes
mwojtyczka Feb 5, 2025
5e9a235
revert changes
mwojtyczka Feb 5, 2025
6a2f5fb
updated acceptance tests config
mwojtyczka Feb 5, 2025
91aa7d1
updated acceptance tests config
mwojtyczka Feb 5, 2025
5b06bd0
Merge branch 'main' into dependencies_update
mwojtyczka Feb 10, 2025
b8e0f0a
Merge branch 'main' into dependencies_update
mwojtyczka Feb 12, 2025
029f1e6
Merge branch 'main' into dependencies_update
mwojtyczka Feb 13, 2025
c472f0d
added nightly ci
mwojtyczka Feb 13, 2025
fc7269e
updated documentation
mwojtyczka Feb 13, 2025
5b78ce7
updated documentation
mwojtyczka Feb 13, 2025
9685056
updated documentation
mwojtyczka Feb 13, 2025
f9a8cb8
updated documentation
mwojtyczka Feb 13, 2025
28abc3f
refactored test
mwojtyczka Feb 13, 2025
5a5df94
Merge branch 'main' into dependencies_update
mwojtyczka Feb 13, 2025
afe2b93
removed duplicated tests
mwojtyczka Feb 13, 2025
6e5c5b3
refactor
mwojtyczka Feb 13, 2025
68612f5
updated ci
mwojtyczka Feb 13, 2025
ac4fdff
refactored pyproject.toml
mwojtyczka Feb 13, 2025
dd89cd7
updated make to always open the coverage report even if any test fails
mwojtyczka Feb 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ concurrency:

jobs:
integration:
if: github.event_name == 'pull_request' && github.event.pull_request.draft == false
# Only run this job for PRs from branches on the main repository and not from forks.
# Workflows triggered by PRs from forks don't have access to the tool environment.
# PRs from forks to be tested by the reviewer(s) / maintainer(s) before merging.
if: github.event_name == 'pull_request' && !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork
environment: tool
runs-on: larger
steps:
Expand Down Expand Up @@ -55,7 +58,10 @@ jobs:
ARM_TENANT_ID: ${{ secrets.ARM_TENANT_ID }}

serverless_integration:
if: github.event_name == 'pull_request' && github.event.pull_request.draft == false
# Only run this job for PRs from branches on the main repository and not from forks.
# Workflows triggered by PRs from forks don't have access to the tool environment.
# PRs from forks to be tested by the reviewer(s) / maintainer(s) before merging.
if: github.event_name == 'pull_request' && !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork
environment: tool
runs-on: larger
env:
Expand Down
2 changes: 1 addition & 1 deletion docs/dqx/docs/installation.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The framework can be installed on a Databricks workspace or used as a standalone
- Python 3.10 or later. See [instructions](https://www.python.org/downloads/).
- Unity Catalog-enabled [Databricks workspace](https://docs.databricks.com/en/getting-started/index.html).
- Network access to your Databricks Workspace used for the installation process.
- (Optional) Databricks CLI v0.213 or later. See [instructions](https://docs.databricks.com/dev-tools/cli/databricks-cli.html).
- (Optional) Databricks CLI v0.241 or later. See [instructions](https://docs.databricks.com/dev-tools/cli/databricks-cli.html).
- Databricks Runtime with Spark 3.5.0 or higher. See [instructions](https://docs.databricks.com/clusters/create.html).

## DQX installation as a Library
Expand Down
1 change: 1 addition & 0 deletions labs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: dqx
description: Data Quality Framework for PySpark Workloads
install:
script: src/databricks/labs/dqx/installer/install.py
extras: cli
uninstall:
script: src/databricks/labs/dqx/installer/uninstall.py
entrypoint: src/databricks/labs/dqx/cli.py
Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ classifiers = [
dependencies = ["databricks-labs-blueprint>=0.9.1,<0.10",
"databricks-sdk~=0.30",
"databricks-labs-lsql>=0.5,<0.15",
"pyspark~=3.5.0" # required by the CLI to work correctly
]

[project.optional-dependencies]
cli = ["pyspark~=3.5.0"]

[project.entry-points.databricks]
runtime = "databricks.labs.dqx.runtime:main"

Expand Down Expand Up @@ -70,6 +72,7 @@ dependencies = [
"types-PyYAML~=6.0.12",
"types-requests~=2.31.0",
"databricks-connect~=15.4",
"pyspark~=3.5.0",
]

python="3.10"
Expand Down