Fix bug with the selectRows cache not being cleared when labeling concepts in HF. #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Sep 14, 2023
| total_num_rows: res.total_num_rows | ||
| }; | ||
| }, | ||
| [DATASETS_TAG, 'selectRows', namespace, datasetName] |
There was a problem hiding this comment.
maybe we don't need to specify namespace and datasetnmae in tags, since createAPIQUery will add all args at the end ? I guess it would make a difference if we ever do invalidateQuery('selectrows', namespace, datasetName)
There was a problem hiding this comment.
Yeah, I did it this way to mirror what we do for infiniteSelectRows (and in general we should probably try to invalidate exactly what needs to be invalidate, generally we just invalidate all datasets).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens in HF because we have a production-deployment that changes the names of functions!
Throwback to closure compilation issues ;)