Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with urls that end with a slash. #1143

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Fix issue with urls that end with a slash. #1143

merged 3 commits into from
Jan 29, 2024

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Jan 29, 2024 •
edited
Loading

We do this by fixing the order of requests on the server-side.

The order:

  • serve static files from _app first
  • redirect any urls that end with slash to the same version without a slash
  • serve the html file given the path

https://huggingface.co/spaces/lilacai/nikhil_staging

@nsthorat nsthorat requested a review from dsmilkov January 29, 2024 18:36
@nsthorat nsthorat merged commit a7c3462 into main Jan 29, 2024
4 checks passed
@nsthorat nsthorat deleted the nik-url branch January 29, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmilkov dsmilkov dsmilkov approved these changes

Assignees
No one assigned
Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsthorat @dsmilkov