Skip to content

Commit

Permalink
Fixed Donald comments for PR
Browse files Browse the repository at this point in the history
  • Loading branch information
khoroshevskyi committed Dec 19, 2024
1 parent c3b4bcf commit 4c9891b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions bbconf/config_parser/bedbaseconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ def _init_qdrant_text_backend(self) -> Union[QdrantBackend, None]:
qdrant_host=self.config.qdrant.host,
qdrant_api_key=self.config.qdrant.api_key,
)
except Exception as _:
_LOGGER.error("Error in Connection to qdrant text! skipping...")
except Exception as e:
_LOGGER.error(f"Error in Connection to qdrant text! skipping {e}")
warnings.warn(
"Error in Connection to qdrant text! skipping...", UserWarning
)
Expand Down
8 changes: 6 additions & 2 deletions bbconf/modules/bedfiles.py
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,8 @@ def _update_ref_validation(
"""
Update reference validation data
! This function won't update the reference validation data, if it exists, it will skip it.
:param sa_session: sqlalchemy session
:param bed_object: bed sqlalchemy object
:param ref_validation: bed file metadata
Expand Down Expand Up @@ -1018,11 +1020,13 @@ def upload_pephub(self, identifier: str, metadata: dict, overwrite: bool = False
overwrite=overwrite,
)

def update_pephub(self, identifier: str, metadata: dict, overwrite: bool = False):
def update_pephub(
self, identifier: str, metadata: dict, overwrite: bool = False
) -> None:
try:
if not metadata:
_LOGGER.warning("No metadata provided. Skipping pephub upload..")
return False
return None
self._config.phc.sample.update(
namespace=self._config.config.phc.namespace,
name=self._config.config.phc.name,
Expand Down

0 comments on commit 4c9891b

Please sign in to comment.