-
Notifications
You must be signed in to change notification settings - Fork 70
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
š» Bump version to v1.11.0 and update screenshots and README
- Loading branch information
1 parent
24c516e
commit 6094584
Showing
4 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
6094584There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the new presets have some issue, like previously the container (example. mkv) and format (example. 137+140) can be selected separately but with this new update to set this kind of preference, user needs to create a custom preset, which might annoy most of the time, as the container and the format listed under preset instead of two separate category.
6094584There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also under the custom preset option while editing the format and container, there is no drop-down list function to show the list of the items available, this makes it hard to create the preset, and need to go to the main preset drop-down and lookup the values and come back to enter the values.
I feel like this needs to changed.
6094584There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long run, it should be easier to switch back and forth between presets than to separately select container and format. Also Iām curious why you want 137+140 in mkv.
If you want to create a custom preset based on a builtin preset, select the builtin preset and click āduplicateā, then edit it.
Thereās no need to look up builtin presets, because builtin presets are just my opinionated defaults. They do not reflect the full capabilities of the backend.
Thereās no drop-down list in the preset editor, because the format and container fields actually correspond to the specified format and container. Previously the predefined containers and formats are actually of the same
Formattype in code, because some formats have to specify a container, or even extra arguments.In my opinion the new layout is easier to understand, customize and use. And it actually reflects the logic behind it, thus the code is also much cleaner.
6094584There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, in the previous version the logs used to reset at every new downloads, but in this one, it's not.
furthermore, there are new logs that can be seen from the app every time launch as new at front referring to the some backend connections are notifications which was never there before.
is it possible disable the logs in the settings, or will it be implemented in future?
6094584There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional. In older versions, the logs were actually called "output", which kind of makes sense to clear the "output" before each new run.
Starting with this version, a logging framework is used to propagate the logs. It doesn't make sense anymore to clear the logs.
https://stackoverflow.com/questions/30352447/using-reactiveuis-bindto-to-update-a-xaml-property-generates-a-warning These warnings probably should have been at debug level. I'll check with RxUI developers to see if we can change the log level of these messages.
Do you really want to completely disable logging? Format listings are also only displayed in logs.
Also please use discussions or issues for these types of questions. It's easier for other users to discover and participate, and for me to keep track of.