Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQL5 support #45

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

MQL5 support #45

wants to merge 11 commits into from

Conversation

artbert
Copy link

@artbert artbert commented Oct 3, 2019

The pull request includes proposal of my version of MQL5 support.
The idea was to:

  • use new type of mql5 application type Service instead of EA
  • prepare main interface to better reflect mql5 trading rules
  • simplify a little bit message format communication

Please see [mql5/README.md] to read detailed information about my implementation.
I created new python files to not make mess in the project. Their names have '_MT5' suffix.
Final explanation of the ideas was placed as a commentary to the mql5 code.

artbert added 11 commits October 2, 2019 21:09
I added new type of MQL application called 'Service' with MQL5 support for DWX_ZeroMQ.
Fix small bugs at ServiceInit and DWX_GetTickData functions.
I added modified DWX_ZeroMQ_Connector file ready to work with service implemented in DWX_ZeroMQ_Service_v1.0.0.mq5 file.
I added Execution and Reporting modules modified to work with api implemented in DWX_ZeroMQ_Connector_v1_0.py file
I added Strategy module modified to work with api implemented in DWX_ZeroMQ_Connector_v1_0.py file.
I added coin flip traders strategy modified to work with api implemented in DWX_ZeroMQ_Connector_v1_0.py file.
I added few examples.
I corrected few spelling mistakes and reformatted data presentation.
@integracore2
Copy link
Collaborator

Hi @artbert ,

Thank you so much for your contribution! 😃

We'll review this as soon as we can - many thanks!

@jmarunix
Copy link

Hi,
I want to thanks all the people and your work, this project is amazing!!
And of course too, to @artbert, your proposal to MQL5 support works very fine with my config:
An old Pc with Debian + Wine + Metatrader5(32 Bits)

Copy link

@Qoyyuum Qoyyuum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper README doc. Tested the code and it works as expected on a standard fresh Windows 10 machine with MT5 64bit installed.

@Zeta90
Copy link

Zeta90 commented Jan 4, 2021

Hi,
I want to thanks all the people and your work, this project is amazing!!
And of course too, to @artbert, your proposal to MQL5 support works very fine with my config:
An old Pc with Debian + Wine + Metatrader5(32 Bits)

GOD Bless u, mate

@brunobuger
Copy link

Amazing!
I'll test soon, we can dockerize if everything is working fine.
@artbert @jmarunix @Zeta90 any of you was able to run a simple performance comparison between Windows(native) and Linux(Wine/'emulated') ?

@Qoyyuum
Copy link

Qoyyuum commented Jan 7, 2021

Amazing!
I'll test soon, we can dockerize if everything is working fine.

Run a separate pull request for a dockerize version of this connector and I'll help with the review.

@ivascen
Copy link

ivascen commented Feb 4, 2021

Any idea when this PR could be merged into master ?

@dominicfallows
Copy link

This would be great to merge into master, any update on when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants