Use the 'dart compile js-dev' command for invoking DDC …

[a-siva]

Use the 'dart compile js-dev' command for invoking DDC instead of reaching into the dart-sdk and using the snapshot which is an internal implementation detail of the dart sdk.

[github-actions]

PR Health

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

[jakemac53]

Once we have a released dev SDK to depend on, I can update the CI jobs etc and push that here.

[jakemac53]

cc @a-siva @nshahan something seems to be broken with the dart compile js-dev command on windows? I am not getting a lot of useful information from the GitHub logs though.

[a-siva]

cc @a-siva @nshahan something seems to be broken with the dart compile js-dev command on windows? I am not getting a lot of useful information from the GitHub logs though.

Will investigate, looks like tests are waiting for temp directories to get deleted but they are in use, could be a test issue.

[jakemac53]

Will investigate, looks like tests are waiting for temp directories to get deleted but they are in use, could be a test issue.

I think that possibly the worker isn't shutting down like it normally would.

[jakemac53]

Note that we just send it a sigterm by calling Process.kill. I don't know how the dart tool deals with that, and if it can handle shutting down its sub-processes etc.

[a-siva]

Note that we just send it a sigterm by calling Process.kill. I don't know how the dart tool deals with that, and if it can handle shutting down its sub-processes etc.

It does not handle shutting down sub-processes, if that is the issue we should also see errors on other platforms (linux, mac)

[jakemac53]

It does not handle shutting down sub-processes, if that is the issue we should also see errors on other platforms (linux, mac)

Well, only windows won't allow deleting a directory because some sub-process has file handles in that directory still open. So it is possible that is the only reason we don't see the error on other platforms. If the process is left dangling though that is of course bad.

[davidmorgan]

Thanks Siva.

It's impossible to review with the reformat ... I've sent #3870 to do the reformat separately, could you please rebase after that lands?

Then, happy to take a look if you'd like to land this, please let me know.

[a-siva]

Closing this PR in favor of a new PR which would be done post the reformat PR.