Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on the measuring performance page #3649

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

jakemac53
Copy link
Contributor

Closes #3648

@FufferKS does this help?

@jakemac53 jakemac53 requested a review from natebosch February 12, 2024 17:00
@jakemac53 jakemac53 changed the title Update measuring_performance.md Update docs on the measuring performance page Feb 12, 2024
@FufferKS
Copy link

Amazing, thanks for replying on such a short notice!

This is definitely helpful, if you don't mind I will ask some more in depth questions tomorrow.

### Hide skipped actions

Many actions in a build are "optional", which means they only run if some other
action asks to read their output. This setting toggles whether those rows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checking - is skipped only the optional assets, or does it include not-invalidated assets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-invalidated ones won't show up at all no matter what afaik

Co-authored-by: Nate Bosch <nbosch@google.com>
@jakemac53 jakemac53 merged commit 76afd1a into master Feb 13, 2024
70 checks passed
@jakemac53 jakemac53 deleted the jakemac53-patch-1 branch February 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[build_runner] More comprehensive measuring_performance.md
3 participants