Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert use of autoload #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert use of autoload #21

wants to merge 1 commit into from

Conversation

jcs
Copy link

@jcs jcs commented Jul 12, 2020

Hi, I'm using this module on OpenBSD in an environment that uses its pledge mechanism to restrict the functionality of the program for increased security when parsing untrusted images.

The 0.4.0 release of gd2-ffij changed the behavior to autoload classes at runtime, which breaks my application because it's not allowed to read additional files once pledge has been called. The previous release used require so the entirety of the gd2-ffij module was loaded by the time my application called pledge to lock things down.

Could this use of autoload be reverted to go back to require each dependency up front?

020191e switched from loading GD2 classes upfront to requiring
them at runtime, which may not be desirable for security reasons.
@dark-panda
Copy link
Owner

dark-panda commented Jul 15, 2020 via email

@jcs
Copy link
Author

jcs commented Apr 28, 2021

Sure, that would be fine by me. Either way so I don't have to maintain a forked repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants