Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uploading files no longer working #46

Open
tormodb opened this issue Jul 27, 2020 · 4 comments
Open

uploading files no longer working #46

tormodb opened this issue Jul 27, 2020 · 4 comments
Assignees

Comments

@tormodb
Copy link

tormodb commented Jul 27, 2020

Thanks for this fantastic package, I really hope you are able to recruit a new maintainer for this! I am not sure if this is an easy fix or not, but when I try to upload files I am getting the following error:

Error in curl::curl_fetch_memory(url, handle = handle) : HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1)

Is that due to an API change at canvas you think?

bbbruce added a commit that referenced this issue Aug 23, 2020
… file upload #46.  Left response as list if unable to flatten to data.frame likely fixing #44.  Other changes to simplify code.
@bbbruce
Copy link
Collaborator

bbbruce commented Aug 23, 2020

Please see if the changes I pushed a10c15d just now solved your problem. Please note that I've changed the "setup" in two ways. First, the API token is now more securely stored in your OS's keyring and that setting the domain is a per session setting.

@bbbruce bbbruce self-assigned this Aug 23, 2020
@scottkosty
Copy link
Contributor

@tormodb Do you have time to test the fix (see the comment above)?

@tormodb
Copy link
Author

tormodb commented Sep 16, 2020

hi @scottkosty - sorry for taking so long to respond, but YES - this works now. Fantastic work!

@scottkosty
Copy link
Contributor

@tormodb Thanks for confirming! Glad that the fix by @bbbruce works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants