Fixed Jobs SDK bugs #1456
Merged
Fixed Jobs SDK bugs #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Time property and not Schedule Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
WhitWaldo
changed the title
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
philliphoff
reviewed
Feb 11, 2025
philliphoff
previously approved these changes
Feb 11, 2025
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
philliphoff
reviewed
Feb 11, 2025
| await context.Request.Body.CopyToAsync(memoryStream, cancellationToken); | ||
| payload = memoryStream.ToArray(); | ||
| using var streamContent = new StreamContent(context.Request.Body); | ||
| payload = await streamContent.ReadAsByteArrayAsync(cancellationToken); |
There was a problem hiding this comment.
Should work just as well, though I was specifically thinking of (I think) context.Request.Body.ReadAsByteArrayAsync().
There was a problem hiding this comment.
Haha, whoops. For some reason, Intellisense isn't showing that as an option - I'll have to look into why.
philliphoff
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed reported bugs at #1455 and #1457
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1455
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: