Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow deploy script #282

Merged
merged 66 commits into from
Feb 20, 2025
Merged

Add flow deploy script #282

merged 66 commits into from
Feb 20, 2025

Conversation

loic1
Copy link
Contributor

@loic1 loic1 commented Feb 17, 2025

Add script deploying evm contracts from flow in order to sign transactions with account key details specified in flow.json / kms signers - this replaces the Solidity deploy script used for initial testing

@loic1 loic1 marked this pull request as ready for review February 19, 2025 03:55
@loic1 loic1 requested a review from a team as a code owner February 19, 2025 03:55
@@ -1,7 +1,7 @@
[profile.default]
solc_version = "0.8.24"
optimizer = true
optimizer_runs = 200
optimizer_runs = 50000
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judezhu increased optimizer runs to make function executions less expensive

More details:

Before you deploy your contract, activate the optimizer when compiling using solc --optimize --bin sourceFile.sol. By default, the optimizer will optimize the contract assuming it is called 200 times across its lifetime (more specifically, it assumes each opcode is executed around 200 times). If you want the initial contract deployment to be cheaper and the later function executions to be more expensive, set it to --optimize-runs=1. If you expect many transactions and do not care for higher deployment cost and output size, set --optimize-runs to a high number. This parameter has effects on the following (this might change in the future):

  • the size of the binary search in the function dispatch routine

  • the way constants like large numbers or strings are stored

https://docs.soliditylang.org/en/latest/using-the-compiler.html#optimizer-options

loic1 and others added 4 commits February 19, 2025 13:35
* updated script

* updated topshot collection metadata

* remove unused log

* updated read me

* upgraded go script modules

* fixed comments
Copy link
Contributor

@judezhu judezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@loic1 loic1 changed the base branch from loic/implement-wrapper-functionality to evm-bridging February 20, 2025 17:18
@loic1 loic1 merged commit 3bfc5da into evm-bridging Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants