parameterize address in metdata view

dapperlabs · Feb 19, 2025 · bea276f · bea276f
1 parent db51016
commit bea276f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/contracts/TopShot.cdc b/contracts/TopShot.cdc
@@ -1743,8 +1743,7 @@ access(all) contract TopShot: NonFungibleToken {
                 return CrossVMMetadataViews.EVMPointer(
                     cadenceType: Type<@TopShot.NFT>(),
                     cadenceContractAddress: self.account.address,
-                    // TODO: Replace with actual EVM contract address
-                    evmContractAddress: EVM.addressFromString("0x1234565789012345657890123456578901234565"),
+                    evmContractAddress: EVM.addressFromString(${EVMCONTRACTADDRESS}),
                     nativeVM: CrossVMMetadataViews.VM.Cadence
                 )
         }

diff --git a/lib/go/contracts/contracts.go b/lib/go/contracts/contracts.go
@@ -31,6 +31,7 @@ const (
 	defaultEVMAddress                  = "EVMADDRESS"
 	defaultCrossVMMetadataViewsAddress = "CROSSVMMETADATAVIEWSADDRESS"
 	defaultNetwork                     = "${NETWORK}"
+	defaultEVMContractAddress          = "${EVMCONTRACTADDRESS}"
 	fastBreakFile                      = "FastBreakV1.cdc"
 	crossVMMetadataViewsFile           = "imports/CrossVMMetadataViews.cdc"
 )
@@ -59,7 +60,9 @@ func GenerateTopShotContract(ftAddr, nftAddr, metadataViewsAddr, viewResolverAdd
 
 	codeWithNetwork := strings.ReplaceAll(codeWithTopShotRoyaltyAddr, defaultNetwork, network)
 
-	return []byte(codeWithNetwork)
+	codeWithEVMContractAddress := strings.ReplaceAll(codeWithNetwork, defaultEVMContractAddress, evmAddr)
+
+	return []byte(codeWithEVMContractAddress)
 }
 
 // GenerateTopShotShardedCollectionContract returns a copy

diff --git a/lib/go/contracts/internal/assets/assets.go b/lib/go/contracts/internal/assets/assets.go