Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async-ify codebase #45

Open
danobi opened this issue Dec 13, 2023 · 0 comments
Open

async-ify codebase #45

danobi opened this issue Dec 13, 2023 · 0 comments

Comments

@danobi
Copy link
Owner

danobi commented Dec 13, 2023

vmtest is more or less a wrapper around qemu stuff. So it's almost completely
I/O bound, making it a good candidate for async.

Async is particularly appealing cuz we have a bunch of threads in places where
we don't want blocking semantics. And the threads are getting a bit hacky (for
example most of them are never joined and implicitly require the other end of
a socket to hang up for the thread to exit). Aync would let you select
on multiple futures allowing for cleaner cancellation semantics.

Overall I think the codebase would be cleaner with async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant