Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 refactor: Prevent Vertex AI from Setting Parameter Defaults #5653

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Feb 5, 2025

Summary

The VertexAI client was setting defaults for model parameters that was adversely affecting generation, namely with a limited amount of maxOutputTokens

  • Updated @librechat/agents package from version 2.0.0 to 2.0.1 for improved functionality
  • Enhanced VertexAI client initialization by explicitly setting client parameters instead of relying on defaults
  • Improved stream handling by properly typing the client and managing chunk text processing
  • Implemented robust metadata processing by filtering out NaN values and ensuring proper concatenation
  • Removed unnecessary default configurations and legacy maxRetries setting
  • Refined the client initialization process for both VertexAI and GenAI implementations

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila danny-avila changed the title refactor: Prevent Vertex AI Client from Setting Parameter Defaults 🤖 refactor: Prevent Vertex AI from Setting Parameter Defaults Feb 5, 2025
@danny-avila danny-avila merged commit 6c33dc2 into main Feb 5, 2025
2 checks passed
@danny-avila danny-avila deleted the refactor/google-defaults branch February 5, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant