Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔈fix: Accessible name on 'Prev' button in Prompts UI #5369

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Jan 20, 2025

Fixes #5310

Add aria-label="previous" attribute to the 'Prev' button in the Prompts Panel.

  • Modify client/src/components/Chat/Prompts.tsx to include aria-label="previous" attribute for the button.

Change Type

  • Bug fix

Testing

Tested on Desktop Firefox and Mobile Chrome

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

Fixes #5310

Add `aria-label="previous"` attribute to the 'Prev' button in the Prompts Panel.

* Modify `client/src/components/Chat/Prompts.tsx` to include `aria-label="previous"` attribute for the button.
@berry-13 berry-13 changed the title Fix incomplete accessible name on 'Prev' button in Prompts Panel 🔈fix: ncomplete accessible name on 'Prev' button in Prompts Panel Jan 20, 2025
@berry-13 berry-13 changed the title 🔈fix: ncomplete accessible name on 'Prev' button in Prompts Panel 🔈fix: incomplete accessible name on 'Prev' button in Prompts Panel Jan 20, 2025
@danny-avila danny-avila changed the title 🔈fix: incomplete accessible name on 'Prev' button in Prompts Panel 🔈fix: Accessible name on 'Prev' button in Prompts UI Jan 20, 2025
@danny-avila danny-avila merged commit 79585e2 into main Jan 20, 2025
2 checks passed
@danny-avila danny-avila deleted the berry-13/fix-prev-button-accessibility branch January 20, 2025 22:14
owengo pushed a commit to openwengo/LibreChat that referenced this pull request Jan 21, 2025
Fixes danny-avila#5310

Add `aria-label="previous"` attribute to the 'Prev' button in the Prompts Panel.

* Modify `client/src/components/Chat/Prompts.tsx` to include `aria-label="previous"` attribute for the button.
lpirola pushed a commit to lpirola/LibreChat that referenced this pull request Jan 22, 2025
Fixes danny-avila#5310

Add `aria-label="previous"` attribute to the 'Prev' button in the Prompts Panel.

* Modify `client/src/components/Chat/Prompts.tsx` to include `aria-label="previous"` attribute for the button.
justinmdickey pushed a commit to e-gineering/LibreChat that referenced this pull request Jan 30, 2025
Fixes danny-avila#5310

Add `aria-label="previous"` attribute to the 'Prev' button in the Prompts Panel.

* Modify `client/src/components/Chat/Prompts.tsx` to include `aria-label="previous"` attribute for the button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete accessible name on "Prev" button in Prompts Panel
2 participants