📜 refactor: Log Error Messages when OAuth Fails #5337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When OAuth Authentication fails, passport is configured to redirect to login page, the error message is stored in req.session.messages but not logged. Resulting in no OAuth logs being printed and making it harder to debug OAuth issues.
This fix adds a new route
/oauth/error
to handle and log OAuth errors before redirecting to login page.Change Type
Please delete any irrelevant options.
Testing
Any previously failed OAuth login attempts without any errors logged will log after this commit.
For me, Currently ES256 JWT algorithm results in OAuth failure and no logs produced, tested that the error message is logged correctly after the change.
Test Configuration:
Checklist
Please delete any irrelevant options. (removed documentation items)