Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🖼️ style: Conversation Menu and Dialogs update #3601

Merged
merged 25 commits into from
Aug 16, 2024
Merged

🖼️ style: Conversation Menu and Dialogs update #3601

merged 25 commits into from
Aug 16, 2024

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Aug 9, 2024 •
edited
Loading

Summary

dropdown update and dialogs update

Change Type

  • Style

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@danny-avila danny-avila marked this pull request as draft August 9, 2024 22:14
@berry-13 berry-13 marked this pull request as ready for review August 15, 2024 18:37
@danny-avila danny-avila changed the title style: dropdown update and dialogs update 🖼️ style: dropdown update and dialogs update Aug 16, 2024
@danny-avila danny-avila changed the title 🖼️ style: dropdown update and dialogs update 🖼️ style: Conversation Menu and Dialogs update Aug 16, 2024
@danny-avila danny-avila merged commit 96581d5 into main Aug 16, 2024
5 checks passed
@danny-avila danny-avila deleted the new-dropdown branch August 16, 2024 08:30
danny-avila added a commit that referenced this pull request Aug 17, 2024
@berry-13 @danny-avila
🖼️ style: Conversation Menu and Dialogs update (#3601)
036b1e2 
* feat: new dropdown

* fix: maintain popover active when open

* fix: update DeleteButton and ShareButton component to use useState for managing dialog state

* BREAKING: style improvement of base Button component

* style: update export button

* a11y: ExportAndShareButton

* add border

* quick style fix

* fix: flick issue on convo

* fix: DropDown opens when renaming

* chore: update radix-ui/react-dropdown-menu to latest

* small fix

* style: bookmarks update

* reorder export modal

* feat: imporved dropdowns

* style: a lot of changes; header, bookmarks, export, nav, convo, convoOptions

* fix: small style issues

* fix: button

* fix: bookmarks header menu

* fix: dropdown close glitch

* feat: Improve accessibility and keyboard navigation in ModelSpec component

* fix: Nav related type issues

* style: ConvoOptions theming and focus ring

---------

Co-authored-by: Danny Avila <danny@librechat.ai>
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
@berry-13 @danny-avila
🖼️ style: Conversation Menu and Dialogs update (danny-avila#3601)
6a2fac9 
* feat: new dropdown

* fix: maintain popover active when open

* fix: update DeleteButton and ShareButton component to use useState for managing dialog state

* BREAKING: style improvement of base Button component

* style: update export button

* a11y: ExportAndShareButton

* add border

* quick style fix

* fix: flick issue on convo

* fix: DropDown opens when renaming

* chore: update radix-ui/react-dropdown-menu to latest

* small fix

* style: bookmarks update

* reorder export modal

* feat: imporved dropdowns

* style: a lot of changes; header, bookmarks, export, nav, convo, convoOptions

* fix: small style issues

* fix: button

* fix: bookmarks header menu

* fix: dropdown close glitch

* feat: Improve accessibility and keyboard navigation in ModelSpec component

* fix: Nav related type issues

* style: ConvoOptions theming and focus ring

---------

Co-authored-by: Danny Avila <danny@librechat.ai>
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
@berry-13 @danny-avila
🖼️ style: Conversation Menu and Dialogs update (danny-avila#3601)
cc5fafc 
* feat: new dropdown

* fix: maintain popover active when open

* fix: update DeleteButton and ShareButton component to use useState for managing dialog state

* BREAKING: style improvement of base Button component

* style: update export button

* a11y: ExportAndShareButton

* add border

* quick style fix

* fix: flick issue on convo

* fix: DropDown opens when renaming

* chore: update radix-ui/react-dropdown-menu to latest

* small fix

* style: bookmarks update

* reorder export modal

* feat: imporved dropdowns

* style: a lot of changes; header, bookmarks, export, nav, convo, convoOptions

* fix: small style issues

* fix: button

* fix: bookmarks header menu

* fix: dropdown close glitch

* feat: Improve accessibility and keyboard navigation in ModelSpec component

* fix: Nav related type issues

* style: ConvoOptions theming and focus ring

---------

Co-authored-by: Danny Avila <danny@librechat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berry-13 @danny-avila