Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 chore: pre-release cleanup 2 #3600

Merged
merged 9 commits into from
Aug 9, 2024
Merged

🧹 chore: pre-release cleanup 2 #3600

merged 9 commits into from
Aug 9, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Aug 9, 2024

Summary

  • Added a unique index for conversationId and user in the convoSchema to ensure data integrity and improve query performance.
  • Created a new searchConversation function in the Conversation model to efficiently retrieve only necessary fields (conversationId and user) when validating conversation access.
  • Updated the validateConvoAccess middleware to use the new searchConversation function, improving the efficiency of access validation.
  • Refactored the scrollToEnd utility function in the client to remove the setTimeout delay, providing a better, more immediate, less prone to error effect
  • Edited dynamic font sizes in style.css to use the font-size-base variable from 1rem for better consistency:

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing

To test these changes:

  1. Verify that creating conversations with duplicate conversationId and user combinations is not possible.
  2. Test the conversation access validation by attempting to access conversations with various user and conversationId combinations.
  3. Check the performance of conversation queries, especially in scenarios with a large number of conversations.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have added necessary database indexes to improve query performance
  • I have tested the changes to ensure they do not negatively impact existing functionality

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila
…tion

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila
@danny-avila danny-avila mentioned this pull request Aug 9, 2024
10 tasks

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila
…nType values

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila
…for generating token and hash
@danny-avila danny-avila merged commit 1ff4841 into main Aug 9, 2024
5 checks passed
@danny-avila danny-avila deleted the chore/pre-release-2 branch August 9, 2024 19:17
danny-avila added a commit that referenced this pull request Aug 17, 2024

Verified

This commit was signed with the committer’s verified signature.
danny-avila Danny Avila
* refactor: scrollToEnd

* fix(validateConvoAccess): search conversation by ID for proper validation

* feat: Add unique index for conversationId and user in convoSchema

* refactor: Update font sizes 1 rem -> font-size-base in style.css

* fix: Assistants map type issues

* refactor: Remove obsolete scripts

* fix: Update DropdownNoState component to handle both string and OptionType values

* refactor: Remove config/loader.js file

* fix: remove crypto.randomBytes(); refactor: Create reusable function for generating token and hash
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
* refactor: scrollToEnd

* fix(validateConvoAccess): search conversation by ID for proper validation

* feat: Add unique index for conversationId and user in convoSchema

* refactor: Update font sizes 1 rem -> font-size-base in style.css

* fix: Assistants map type issues

* refactor: Remove obsolete scripts

* fix: Update DropdownNoState component to handle both string and OptionType values

* refactor: Remove config/loader.js file

* fix: remove crypto.randomBytes(); refactor: Create reusable function for generating token and hash
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
* refactor: scrollToEnd

* fix(validateConvoAccess): search conversation by ID for proper validation

* feat: Add unique index for conversationId and user in convoSchema

* refactor: Update font sizes 1 rem -> font-size-base in style.css

* fix: Assistants map type issues

* refactor: Remove obsolete scripts

* fix: Update DropdownNoState component to handle both string and OptionType values

* refactor: Remove config/loader.js file

* fix: remove crypto.randomBytes(); refactor: Create reusable function for generating token and hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant