-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ style: Update Messages Style to Match ChatGPT (ChatGPT UI) #2741
✨ style: Update Messages Style to Match ChatGPT (ChatGPT UI) #2741
Conversation
@techwithanirudh many of my friends don't want to use the new "Chat bubble". Could we create a switch for it? additionally, can we include this "var" in the "edit messages" PR? |
Note: This code has not been run and is assumed to work, p2 will check if this implementation works and use the recoil state to make modifcations to the UI
fix: use default value as true for messagesUI fix: add com_nav_messages_ui for the text for the switch
Note: Not tested
…fault behaviour in previous versions)
Once this pull request is merged, I will add the conditional check for the parameter in the EditMessages pull request, but other than that everything is done. Update: I have updated the EditMessages functionality to respect the flag. |
Note: As messagesUI is already true expect false
thanks! |
I won't be merging this PR or any of the other UI updates unless there is a way to select different themes for the new UI updates, with the current theme being the default. |
@danny-avila This has already been implemented in this P.R, if this P.R gets merged I could update the others to do the same. |
Ok, I didn't realize that. I will try it out. |
e4ea624
to
7b3285b
Compare
The hover buttons should also hover when the entire message row is being hovered in the new style. currently it does not, and it doesn't feel intuitive to hover over the bubble first. Recording.2024-06-08.183608.mp4 |
@danny-avila I tried to fix this issue, is this fix okay? |
This PR was closed due to fundamental changes made to messages to accommodate this PR #3191 I'm still open to the bubble message look as an option but geared for dependency injection from the start, with minimal code edits to the main message components and Hover buttons. I closed this PR as I don't expect the changes to be reconciled from the current state of the PR which already had some merge conflicts before #3191 |
Summary
Modernized the message components to match ChatGPT’s style and optimized dark mode support.
Desktop
Before:

After:

Before:

After:

Mobile
Before:

After:

Before:

After:

Change Type
Testing
N/A
Test Configuration:
N/A
Checklist