Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖌️ feat: Optional Display Username in Messages, UI improvements, and Localization Updates #1577

Closed
wants to merge 10 commits into from

Conversation

itzraiss
Copy link
Contributor

@itzraiss itzraiss commented Jan 17, 2024

Summary

When the user sends a message, instead of showing 'You' in the sent message, and the agent's name in the received message with whom he is talking, the user's name will be shown, the same one that appears just below in the left corner in Nav. Also added in place of 'You', the translation for its respective language.

Change Type

  • Translation Update
  • Added new feature (Preference in Settings Account to username instead of 'You' when sending messages)
  • Style Buttons Updated

Username:

Before:
Captura de tela 2024-01-16 230628

After:
Captura de tela 2024-01-17 195830

Style Buttons:

Now:
image

@itzraiss itzraiss changed the title 👤add: Username instead of 'You' when sending messages. 👤added: Username instead of 'You' when sending messages. Jan 18, 2024
@danny-avila
Copy link
Owner

Thanks for this! I would prefer if it was a setting based on preference. Could you add it to Settings under Account? if you need guidance on this, let me know.

@itzraiss
Copy link
Contributor Author

Thanks for this! I would prefer if it was a setting based on preference. Could you add it to Settings under Account? if you need guidance on this, let me know.

something like this?
Captura de tela 2024-01-18 065055

@itzraiss itzraiss marked this pull request as draft January 18, 2024 09:56
@danny-avila
Copy link
Owner

Yes except the message should me much shorter and active tense. “Display username in messages”

@SailFlorve
Copy link
Contributor

It should not default, because You is what official ChatGPT shows.

@danny-avila
Copy link
Owner

It should not default, because You is what official ChatGPT shows.

I agree with you, default should be off, although keep in mind the project is not entirely 1:1 with ChatGPT and I do not intend it to be (though obviously there is a lot we do match)

danny-avila and others added 3 commits January 18, 2024 14:44
* feat: Beta features tab in Settings and LaTeX Parsing toggle

* feat: LaTex parsing with spec
* feat(DALL-E-3/DALL-E-2): Azure OpenAI support. New Version specific environment credentials:
 - DALLEx_SYSTEM_PROMPT=
 - DALLEx_AZURE_API_VERSION=
 - DALLEx_BASEURL=
 - DALLEx_API_KEY=
 - replace `x` with `3` or `2`

* docs: update docs based on new env vars and Azure OpenAI support for DALL-E

* docs: breaking change for user provided DALLE_API_KEY:
- **DALL-E Update**: user-provided keys for DALL-E are now specific to each DALL-E version, i.e.:  and
- Note:  will work for both DALL-E-3 and DALL-E-2 when the admin provides the credential; in other words, this may only affect your users if DALLE_API_KEY is not set in the  file. In this case, they will simply have to uninstall the plugin, and provide their API key again.

* refactor: use process.env at runtime instead of from memory to fix testing DALLE3.spec.js, adjust test
chore (StopButon and SendButon): Updated to new style of ChatGPT
chore Update and Added news translations: Spanish, English and Portuguese Brazilian
@itzraiss itzraiss changed the title 👤added: Username instead of 'You' when sending messages. 👤added: Username instead of 'You' when sending messages. / 🎨Update UI Send and Stop button message. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian Jan 19, 2024
@itzraiss itzraiss marked this pull request as ready for review January 19, 2024 01:45
@itzraiss
Copy link
Contributor Author

Thanks for this! I would prefer if it was a setting based on preference. Could you add it to Settings under Account? if you need guidance on this, let me know.

Sorry for the delay in responding. I was at work all day and only managed to address what you asked for tonight. I would have appreciated your guidance; it would have been much quicker and simpler for me. Anyway, here it is, and if you want me to change anything, just let me know. 🙂

@itzraiss itzraiss changed the title 👤added: Username instead of 'You' when sending messages. / 🎨Update UI Send and Stop button message. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian 👤added: Preference in Account to username instead of 'You' when sending messages. / 🎨Updated UI Send and Stop button message. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian Jan 19, 2024
@itzraiss itzraiss changed the title 👤added: Preference in Account to username instead of 'You' when sending messages. / 🎨Updated UI Send and Stop button message. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian 👤added: Preference in Account to username instead of 'You' when sending messages. / 🎨Updated UI Send and Stop message buttons. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian Jan 19, 2024
@itzraiss itzraiss changed the title 👤added: Preference in Account to username instead of 'You' when sending messages. / 🎨Updated UI Send and Stop message buttons. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian 👤added: Preference in Settings Account to username instead of 'You' when sending messages. / 🎨Updated UI Send and Stop message buttons. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian Jan 19, 2024
@itzraiss
Copy link
Contributor Author

itzraiss commented Jan 19, 2024

It should not default, because You is what official ChatGPT shows.

I left it as disabled by default, the only thing I thought would be interesting is that, just like in ChatGPT, the translation of 'You' to its respective language like 'Você' in pt-BR.

@danny-avila
Copy link
Owner

It should not default, because You is what official ChatGPT shows.

I left it as disabled by default, the only thing I thought would be interesting is that, just like in ChatGPT, the translation of 'You' to its respective language like 'Você' in pt-BR.

Thanks so much for the work on this. Going to review it now and I can resolve the conflicts. Sorry I couldn't provide guidance earlier on!

@danny-avila danny-avila changed the title 👤added: Preference in Settings Account to username instead of 'You' when sending messages. / 🎨Updated UI Send and Stop message buttons. / 🌎Updated and Added Translations for Spanish, English and Portuguese Brazilian 🖌️ feat: Optional Display Username in Messages, UI improvements, and Localization Updates Jan 19, 2024
@danny-avila
Copy link
Owner

not a big mess but I made a mistake in pushing the resolution of merge conflicts to your repo! 😬

I've started a new PR with your original commits to clean this up, sorry! #1592

I would fix your fork's main branch but I don't have access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants