Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CDN (Firebase) & feat: account section (OLD) #1261

Closed
wants to merge 23 commits into from
Closed

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Dec 2, 2023

#1438

Summary

I have implemented CDN support using Firebase. Currently, it's specifically designed for uploading profile pictures, but we plan to extend its functionality to support images within the chat and file uploads as well. Additionally, there have been some minor graphical changes, including new icons, and a reorganization of folders in the Settings Tabs. The CDN for profile pictures is currently working for Google, Facebook, Github, and Discord (OpenID support is not yet implemented). Before being uploaded, the images undergo transformation and conversion into the webp format. On average, a profile picture weighs around 3kb, with some as low as 300B. The upload profile picture functionality works for those who don't use Firebase as well. Also, DALL-E plugin support firebase

Here are some frontend images showcasing the image upload

image

image

1202.mp4

fixed some bugs in the settings tab when the theme was light

image

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • Style update
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

...

  • tested automatic disable "auto avatar upload with social logins": Google, Facebook, Github and Discord
  • refactor login tested with Google, Facebook, Github and Discord

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@berry-13 berry-13 linked an issue Dec 2, 2023 that may be closed by this pull request
1 task
@berry-13 berry-13 changed the title feat: CDN (Firebase) feat: CDN (Firebase) 🔥🚀 Dec 3, 2023
@berry-13 berry-13 added the ✨ enhancement New feature or request label Dec 3, 2023
@berry-13 berry-13 linked an issue Dec 6, 2023 that may be closed by this pull request
1 task
@berry-13 berry-13 changed the title feat: CDN (Firebase) 🔥🚀 🔥🚀 feat: CDN (Firebase) & feat: account section Dec 10, 2023
@berry-13 berry-13 marked this pull request as ready for review December 16, 2023 17:44
@danny-avila
Copy link
Owner

For both files in routes and services directories, please move them to files/images.

Any new API endpoints should follow RESTful pattern i.e, /api/files/images/profile

@berry-13 berry-13 changed the title 🔥🚀 feat: CDN (Firebase) & feat: account section feat: CDN (Firebase) & feat: account section (OLD) Dec 26, 2023
@berry-13 berry-13 closed this Dec 26, 2023
@berry-13 berry-13 deleted the Firebase-CDN branch December 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants