Skip to content

Commit

Permalink
fix: prevent convo overwrite on convo refresh and combine with remote…
Browse files Browse the repository at this point in the history
… models handling (#1217)
  • Loading branch information
danny-avila authored Nov 25, 2023
1 parent ebe62ad commit 4dab094
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
22 changes: 14 additions & 8 deletions client/src/routes/ChatRoute.tsx
Original file line number Diff line number Diff line change
@@ -1,31 +1,37 @@
import { useEffect, useRef } from 'react';
import { useParams } from 'react-router-dom';
import { useGetConvoIdQuery } from 'librechat-data-provider';
import { useGetConvoIdQuery, useGetModelsQuery } from 'librechat-data-provider';
import ChatView from '~/components/Chat/ChatView';
import useAuthRedirect from './useAuthRedirect';
import { useSetStorage } from '~/hooks';
import { useNewConvo } from '~/hooks';
import store from '~/store';

export default function ChatRoute() {
const index = 0;
const setStorage = useSetStorage();
const { conversationId } = useParams();
const { conversation, setConversation } = store.useCreateConversationAtom(index);
const { conversation } = store.useCreateConversationAtom(index);
const { isAuthenticated } = useAuthRedirect();
const { newConversation } = useNewConvo();
const hasSetConversation = useRef(false);

const modelsQuery = useGetModelsQuery({ enabled: isAuthenticated });
const initialConvoQuery = useGetConvoIdQuery(conversationId ?? '', {
enabled: isAuthenticated && conversationId !== 'new',
});

useEffect(() => {
if (initialConvoQuery.data && !hasSetConversation.current) {
setStorage(initialConvoQuery.data);
setConversation(initialConvoQuery.data);
if (conversationId === 'new' && modelsQuery.data && !hasSetConversation.current) {
newConversation({ modelsData: modelsQuery.data });
hasSetConversation.current = true;
} else if (initialConvoQuery.data && modelsQuery.data && !hasSetConversation.current) {
newConversation({
template: initialConvoQuery.data,
modelsData: modelsQuery.data,
});
hasSetConversation.current = true;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [initialConvoQuery.data]);
}, [initialConvoQuery.data, modelsQuery.data]);

if (!isAuthenticated) {
return null;
Expand Down
4 changes: 1 addition & 3 deletions client/src/routes/Root.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@ import {
} from 'librechat-data-provider';
import type { ContextType } from '~/common';
import { Nav, MobileNav } from '~/components/Nav';
import { useAuthContext, useServerStream, useConversation, useNewConvo } from '~/hooks';
import { useAuthContext, useServerStream, useConversation } from '~/hooks';
import store from '~/store';

export default function Root() {
const location = useLocation();
const { newConversation } = useConversation();
const { newConversation: newConvo } = useNewConvo();
const { user, isAuthenticated } = useAuthContext();
const [navVisible, setNavVisible] = useState(() => {
const savedNavVisible = localStorage.getItem('navVisible');
Expand Down Expand Up @@ -44,7 +43,6 @@ export default function Root() {
newConversation({}, undefined, modelsQuery.data);
} else if (modelsQuery.data) {
setModelsConfig(modelsQuery.data);
newConvo({ modelsData: modelsQuery.data });
} else if (modelsQuery.isError) {
console.error('Failed to get models', modelsQuery.error);
}
Expand Down

0 comments on commit 4dab094

Please sign in to comment.