Skip to content

Commit

Permalink
🚀 refactor: Use Undici Instead of Node-Fetch, prevent Event Close, ad…
Browse files Browse the repository at this point in the history
…d Index (#3052)

* feat: Add index to conversationId field in messageSchema

* refactor: prevent immediate event close on error

* refactor: use undici instead of node-fetch in non-Bun environment
  • Loading branch information
danny-avila authored Jun 13, 2024
1 parent 29e71e9 commit 4416f69
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion api/app/clients/BaseClient.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const crypto = require('crypto');
const fetch = require('node-fetch');
const { fetch } = require('undici');
const nodeFetch = require('node-fetch');
const { supportsBalanceCheck, Constants } = require('librechat-data-provider');
const { getConvo, getMessages, saveMessage, updateMessage, saveConvo } = require('~/models');
const { addSpaceIfNeeded, isEnabled } = require('~/server/utils');
Expand Down Expand Up @@ -69,6 +70,9 @@ class BaseClient {
url = this.options.reverseProxyUrl;
}
logger.debug(`Making request to ${url}`);
if (typeof Bun !== 'undefined') {
return await nodeFetch(url, init);
}
return await fetch(url, init);
}

Expand Down
1 change: 1 addition & 0 deletions api/models/schema/messageSchema.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const messageSchema = mongoose.Schema(
},
conversationId: {
type: String,
index: true,
required: true,
meiliIndex: true,
},
Expand Down
1 change: 0 additions & 1 deletion client/src/hooks/SSE/useSSE.ts
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,6 @@ export default function useSSE(submission: TSubmission | null, index = 0) {
events.onerror = function (e: MessageEvent) {
console.log('error in server stream.');
startupConfig?.checkBalance && balanceQuery.refetch();
events.close();

let data: TResData | undefined = undefined;
try {
Expand Down

0 comments on commit 4416f69

Please sign in to comment.