Feature/template extensions #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Successfully implemented path-based registry storage - Moved to storing paths instead of full configurations - Implemented proper hash verification for both configs and executables - Registry format now clean and minimal. File-Based Output Implementation - Successfully implemented file-based output handling - Demonstrated clean interface requiring only path output - Properly handles cleanup of temporary files - Verified working with both local and remote operations
Fix issuse with listextension where it would fail if any hash had changed, now says hash failed.
When using pattern files with variables but no stdin input, ensure proper template processing by initializing an empty message. This allows patterns like: ./fabric -p pattern.txt -v=name:value to work without requiring stdin input, while maintaining compatibility with existing stdin usage: echo "input" | ./fabric -p pattern.txt -v=name:value Changes: - Add empty message initialization in BuildSession when Message is nil - Remove redundant template processing of message content - Let pattern processing handle all template resolution This simplifies the template processing flow while supporting both stdin and non-stdin use cases.
This reverts commit 744ec08.
…n.go resulting in segfault. now we make user input ' ', before processing.
fix:added timeout value validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the templating system, and introduces external plugins; extensions
As described by : #1158