Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass GitDSL to handleResults #438

Merged
merged 1 commit into from
Jul 5, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/source/github/events/utils/commenting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ export const commentOnResults = async (
const platform = getPerilPlatformForDSL(dslType, gh, {})
const exec = executorForInstallation(platform, vm2, installationSettings)

// TODO: Figure what happens here with `git` as being nully,
// for one I think it would mean non-sandbox runs cant use inline?
await exec.handleResults(results, {} as any)
// Don't pass a git dsl object here since we don't have one
// This means inline comments won't work
await exec.handleResults(results)
}

/** Pulls out the main ID for commenting on a PR or Issue */
Expand Down