Allow handleResults to be called without a git object #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, looks 👍 I'll get this in, shipped and Peril updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
handleResultsinExecutor.tsrequires that a non-emptyGitDSLobject is passed so that it can add a signature likeDanger.js against COMMIT_HASHto comments. This behaviour was introduced in #783.This is the cause of a crash in Peril, which breaks a common workflow: danger/peril#436.
The updates I have made here are to make
gitan optional parameter inhandleResultsand the templating functions that it calls. If there is nogitobject the signature just doesn't have theagainst COMMIT_HASHpart. I have also added a check so that inline comments won't be added if there is nogitobject since it is required for that.