Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change error handling and message formatting #189

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

mzeevi
Copy link
Contributor

@mzeevi mzeevi commented Jul 16, 2024

No description provided.

This PR includes serveral changes and fixes in error handling across the
different controllers.

Signed-off-by: mzeevi <meytar80@gmail.com>
@mzeevi mzeevi force-pushed the refactor/changeErr branch from 75278ea to ea3d8b8 Compare July 17, 2024 11:57
@mzeevi mzeevi changed the title refactor: change error handling in migration hierarchy refactor: change error handling and message formatting Jul 17, 2024
Copy link
Contributor

@dvirgilad dvirgilad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

dana-prow-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dvirgilad, mzeevi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dana-prow-ci dana-prow-ci bot merged commit e0bf502 into main Jul 17, 2024
3 checks passed
@mzeevi mzeevi deleted the refactor/changeErr branch July 30, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants