group perms for MH and UQ #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvirgilad
changed the title
dvirgilad
force-pushed
the
feature/group_perms
branch
3 times, most recently
from
636e86c to
0c746aa
Compare
mzeevi
requested changes
Apr 2, 2024
dvirgilad
force-pushed
the
feature/group_perms
branch
4 times, most recently
from
afe06b6 to
c2420a6
Compare
This PR introduces a configmap containing a list of comma delimeted "permitted groups". Users in these groups will automatically be able to create an updateQuota or migrationHierarchy, even if they are not admins in the relevant namespaces. Also added test cases for this behavior. Bumped versions for k8s.api, gomega, and docker/login-command
dvirgilad
force-pushed
the
feature/group_perms
branch
from
c2420a6 to
f58effb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dvirgilad, mzeevi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a configmap containing a list of comma delimeted "permitted groups" in config/manager/kustomization.yaml.
Users in these groups will automatically be able to create an updateQuota or migrationHierarchy, Even if they are not admins in the relevant namespaces. Also added test cases for this behavior.