Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permitted groups for UQ and MH #159

Closed
wants to merge 1 commit into from
Closed

permitted groups for UQ and MH #159

wants to merge 1 commit into from

Conversation

dvirgilad
Copy link
Contributor

This PR introduces a configmap containing a list of comma delimeted "permitted groups" in config/manager/kustomization.yaml.

Users in these groups will automatically be able to create an updateQuota or migrationHierarchy, Even if they are not admins in the relevant namespaces. Also added test cases for this behavior.

…permitted groups" in config/manager/kustomization.yaml.

Users in these groups will automatically be able to create an updateQuota or migrationHierarchy, Even if they are not admins in the relevant namespaces.
Also added test cases for this behavior.
@dana-prow-ci dana-prow-ci bot requested a review from mzeevi April 1, 2024 12:37
Copy link
Contributor

dana-prow-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dvirgilad
Once this PR has been reviewed and has the lgtm label, please assign mzeevi for approval by writing /assign @mzeevi in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dvirgilad dvirgilad changed the title peermitted groups for UQ and MH permitted groups for UQ and MH Apr 1, 2024
@dvirgilad dvirgilad closed this Apr 1, 2024
@dvirgilad dvirgilad deleted the group_check branch April 4, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant