chore: change namespace to hns-system instead of sns-system

Signed-off-by: mzeevi <meytar80@gmail.com>

.github/workflows/pr.yaml

@@ -53,4 +53,5 @@ jobs:
         run: make test-e2e
 
       - name: Undeploy HNS
-        run: make undeploy
+        run: make undeploy
+        if: always()

Makefile

@@ -86,8 +86,8 @@ dev: manifests kustomize
 	$(KUSTOMIZE) build config/dev | oc apply -f -
 	mkdir -p $(LOCAL_CERT_DIR)
 	sleep 3
-	kubectl get secret webhook-server-cert -n sns-system -o jsonpath="{.data.tls\.crt}" | base64 --decode > $(LOCAL_CERT_DIR)/tls.crt
-	kubectl get secret webhook-server-cert -n sns-system -o jsonpath="{.data.tls\.key}" | base64 --decode > $(LOCAL_CERT_DIR)/tls.key
+	kubectl get secret webhook-server-cert -n hns-system -o jsonpath="{.data.tls\.crt}" | base64 --decode > $(LOCAL_CERT_DIR)/tls.crt
+	kubectl get secret webhook-server-cert -n hns-system -o jsonpath="{.data.tls\.key}" | base64 --decode > $(LOCAL_CERT_DIR)/tls.key
 
 .PHONY: undev
 undev: manifests kustomize

README.md

@@ -11,10 +11,10 @@ In order to use `HNS`, you need to have:
 
 ## Install with Helm
 
-Helm chart docs are available on `charts/hns` directory. The release name must be `sns`:
+Helm chart docs are available on `charts/hns` directory.
 
 ```bash
-$ helm upgrade sns --install --namespace sns-system --create-namespace oci://ghcr.io/dana-team/helm-charts/hns --version <release>
+$ helm upgrade hns --install --namespace hns-system --create-namespace oci://ghcr.io/dana-team/helm-charts/hns --version <release>
 ```
 
 ### Build

api/v1/types.go

@@ -5,8 +5,8 @@ type Phase string
 const MetaGroup = "dana.hns.io/"
 
 const (
-	SNSNamespace      = "sns-system"
-	SNSServiceAccount = "sns-controller-manager"
+	SNSNamespace      = "hns-system"
+	SNSServiceAccount = "hns-controller-manager"
 )
 
 var DefaultAnnotations = []string{"scheduler.alpha.kubernetes.io/defaultTolerations", "openshift.io/node-selector"}

charts/hns/Chart.yaml

@@ -1,5 +1,5 @@
 apiVersion: v2
-name: sns
+name: hns
 description: A Helm chart for the hns operator.
 
 # A chart can be either an 'application' or a 'library' chart.

config/default/kustomization.yaml

@@ -1,12 +1,12 @@
 # Adds namespace to all resources.
-namespace: sns-system
+namespace: hns-system
 
 # Value of this field is prepended to the
 # names of all resources, e.g. a deployment named
 # "wordpress" becomes "alices-wordpress".
 # Note that it should also match with the prefix (text before '-') of the namespace
 # field above.
-namePrefix: sns-
+namePrefix: hns-
 
 # Labels to add to all resources and selectors.
 #labels:

config/dev/kustomization.yaml

@@ -1,12 +1,12 @@
 # Adds namespace to all resources.
-namespace: sns-system
+namespace: hns-system
 
 # Value of this field is prepended to the
 # names of all resources, e.g. a deployment named
 # "wordpress" becomes "alices-wordpress".
 # Note that it should also match with the prefix (text before '-') of the namespace
 # field above.
-namePrefix: sns-
+namePrefix: hns-
 
 # Labels to add to all resources and selectors.
 #labels:

config/manager/kustomization.yaml

@@ -18,6 +18,5 @@ configMapGenerator:
 - literals:
   - resources="basic.storageclass.storage.k8s.io/requests.storage,cpu,memory,pods,requests.nvidia.com/gpu"
   name: quota-resources
-  namespace: sns-system
   options:
     disableNameSuffixHash: true

internal/quota/configmap.go

@@ -4,6 +4,8 @@ import (
 	"context"
 	"fmt"
 
+	danav1 "github.com/dana-team/hns/api/v1"
+
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	"k8s.io/apimachinery/pkg/types"
@@ -26,14 +28,13 @@ type resourceQuantities struct {
 }
 
 const (
-	namespaceName = "sns-system"
-	configMapName = "sns-config"
+	configMapName = "hns-config"
 )
 
 // getConfigMapData retrieves the ConfigMap data from the cluster.
 func getConfigMapData(ctx context.Context, k8sClient client.Client, key string) (string, error) {
 	cm := &corev1.ConfigMap{}
-	err := k8sClient.Get(ctx, types.NamespacedName{Name: configMapName, Namespace: namespaceName}, cm)
+	err := k8sClient.Get(ctx, types.NamespacedName{Name: configMapName, Namespace: danav1.SNSNamespace}, cm)
 	if err != nil {
 		return "", err
 	}

internal/quota/default.go

@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"strings"
 
+	danav1 "github.com/dana-team/hns/api/v1"
+
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	"k8s.io/apimachinery/pkg/types"
@@ -32,7 +34,7 @@ var (
 	imagestreams      = resource.NewQuantity(100, resource.DecimalSI)
 	ZeroDecimal       = resource.NewQuantity(0, resource.DecimalSI)
 
-	quotaConfig = "sns-quota-resources"
+	quotaConfig = "hns-quota-resources"
 
 	DefaultQuota = corev1.ResourceQuotaSpec{Hard: DefaultQuotaHard}
 
@@ -46,7 +48,7 @@ var (
 // The observed resources are read from a configMap.
 func GetObservedResources(ctx context.Context, k8sClient client.Client) (corev1.ResourceQuotaSpec, error) {
 	resourcesConfig := &corev1.ConfigMap{}
-	if err := k8sClient.Get(ctx, types.NamespacedName{Name: quotaConfig, Namespace: namespaceName}, resourcesConfig); err != nil {
+	if err := k8sClient.Get(ctx, types.NamespacedName{Name: quotaConfig, Namespace: danav1.SNSNamespace}, resourcesConfig); err != nil {
 		return corev1.ResourceQuotaSpec{}, fmt.Errorf("failed to get ConfigMap %q: %v", resourcesConfig, err)
 	}