Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed logging to only support syslogng and elasticsearch #147

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mzeevi
Copy link
Contributor

@mzeevi mzeevi commented Apr 22, 2024

When a user wants logging, now automatcially SyslogNGOutput and SyslogNGFlow objects are created. In addition, support for Splunk has been removed and only Elasticsearch Outputs are supported. A test case has been modified due to a known issue whiich should be fixed in the next release of logging-operator (kube-logging/logging-operator#1140)

@mzeevi mzeevi force-pushed the feature/syslogng branch 3 times, most recently from aea4604 to ecaac45 Compare April 24, 2024 07:08
@mzeevi mzeevi changed the title changed logging to only support syslogng and elasticsearch. changed logging to only support syslogng and elasticsearch Apr 24, 2024
@mzeevi mzeevi force-pushed the feature/syslogng branch 5 times, most recently from 263a08e to a0e2f94 Compare April 24, 2024 14:09
Copy link
Contributor

@fran2810 fran2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over all really good ! nice job few small things but i think maybe the resource mangers should be divided to actions because the the resource managers the Createorupdate are to thick

When a user wants logging, now automatcially SyslogNGOutput
and SyslogNGFlow objects are created. In addition, support for
Splunk has been removed and only Elasticsearch Outputs are supported.
A test case has been modified due to a known issue whiich should be
fixed in the next release of logging-operator (#1140)

Signed-off-by: mzeevi <meytar80@gmail.com>
@mzeevi mzeevi force-pushed the feature/syslogng branch from a0e2f94 to 589dcf8 Compare April 24, 2024 15:38
Copy link
Contributor

@fran2810 fran2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

dana-prow-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fran2810, mzeevi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dana-prow-ci dana-prow-ci bot merged commit d811dcf into dana-team:main Apr 24, 2024
4 checks passed
@mzeevi mzeevi deleted the feature/syslogng branch June 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants