-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed logging to only support syslogng and elasticsearch #147
Conversation
aea4604
to
ecaac45
Compare
263a08e
to
a0e2f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
over all really good ! nice job few small things but i think maybe the resource mangers should be divided to actions because the the resource managers the Createorupdate are to thick
When a user wants logging, now automatcially SyslogNGOutput and SyslogNGFlow objects are created. In addition, support for Splunk has been removed and only Elasticsearch Outputs are supported. A test case has been modified due to a known issue whiich should be fixed in the next release of logging-operator (#1140) Signed-off-by: mzeevi <meytar80@gmail.com>
a0e2f94
to
589dcf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fran2810, mzeevi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When a user wants logging, now automatcially SyslogNGOutput and SyslogNGFlow objects are created. In addition, support for Splunk has been removed and only Elasticsearch Outputs are supported. A test case has been modified due to a known issue whiich should be fixed in the next release of logging-operator (kube-logging/logging-operator#1140)