Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setUseTabs config #642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

MeiyongYu
Copy link

No description provided.

@dail8859
Copy link
Owner

Thanks for the PR, but this setting applies it globally and it needs to be per language. That's why each language can specify the tabSettings option so that is can be configured in NotepadNextApplication::setEditorLanguage().

I know there's no good way yet to configure this per language but having it global would be quite detrimental since it immediately affects all current/future editors.

I'm certainly open to suggestions.

@MeiyongYu
Copy link
Author

MeiyongYu commented Sep 22, 2024

Thanks for the PR, but this setting applies it globally and it needs to be per language. That's why each language can specify the tabSettings option so that is can be configured in NotepadNextApplication::setEditorLanguage().

I know there's no good way yet to configure this per language but having it global would be quite detrimental since it immediately affects all current/future editors.

I'm certainly open to suggestions.

i like sourceinsight style config method, which is global setting,
becase when i open the project i will editor all file which in project as same style.
and the notepad++ is also global config same as sourceinsight.

my next plan:

  1. In edit menu support space and tabs convert command(like sourceinsight)
  2. support multi instance of notepadnext(like source insigt), because i will open almost 3 project in work

@MeiyongYu
Copy link
Author

MeiyongYu commented Sep 22, 2024 via email

@MeiyongYu MeiyongYu closed this Sep 22, 2024
@MeiyongYu MeiyongYu reopened this Sep 22, 2024
@dail8859
Copy link
Owner

i like sourceinsight style config method, which is global setting,
becase when i open the project i will editor all file which in project as same style.
and the notepad++ is also global config same as sourceinsight.

I've never used sourceinsight. If you are wanting more of a global override then that may be a better way to use this setting but it would have to be clear to the user. If this is the intent I can offer some code suggestions but want to make sure that's the plan.

my next plan:
In edit menu support space and tabs convert command(like sourceinsight)

Converting between tabs and spaces is definitely useful.

support multi instance of notepadnext(like source insigt), because i will open almost 3 project in work

Also useful but would take alot more changes that would be worth discussing before code changes are made.

@dail8859
Copy link
Owner

I don't know if you can understand Chinese.

I cannot.

I am using macOS now, but macOS does not support source insight.
I want to add the source insight feature I like to NotepadNext.

The following are the features I want to make.
When I add these advanced features, I will consider maintaining the existing performance of NotepadNext.
Do you have any suggestions?

Basic functions:

  1. Turn off auto-completion, resulting in space errors --close
  2. Support tab and space conversion (from notepad++)

Agreed.

  1. Support highlighting (from notepad++)

In the future I would like some sort of wizard that could import Notepad++ settings and highlighting styles, but right now Notepad Next doesn't have a good way of managing the highlighting styles itself so probably not something worth implementing soon.

  1. Automatically delete trailing spaces

Agreed.

  1. Full project search

I guess the depends how you are defining "project".

Advanced functions:

  1. Support function list (copy form notepad++)

I am not for this feature. Notepad++ has so many issues with it's function list and it is hard to manage. This kind of feature is best left to some sort of plugin. I know Notepad Next does not have plugin support but having this kind of specific functionality that is hard to maintain is not worth having it as a core feature.

  1. Support function jump (from ctags)
  2. Support function association (from cscope)

Same as above, best to keep out of the core functionality since it could be difficult to maintain especially cross platform.

  1. Support project management

This does sound interesting but would need discussed alot more to make sure it lines up with something worth implementing.

  1. Smart rename

Again would need more details.


If there's anything worth discussing more feel free to open a discussion so more details can be specified. I greatly appreciate people wanting to contribute to the project, but my goal is also to make sure the application is useable, maintainable, and code implemented cleanly. So I'm willing to discuss details before someone goes off and puts alot of time into a pull request that might not be implemented in the project.

@MeiyongYu
Copy link
Author

MeiyongYu commented Sep 22, 2024 via email

@MeiyongYu
Copy link
Author

MeiyongYu commented Sep 22, 2024 via email

@dail8859
Copy link
Owner

Lets keep discussions for different features separate. If you want to discuss multi-instance or other features please open discussions so each one can be addressed. It's hard to follow this since all the formatting of the replies are missing.

@MeiyongYu
Copy link
Author

MeiyongYu commented Sep 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants