[ui] Fix awkward messaging on the “Materialize” button when selection is empty #28846
Conversation
bengotow
force-pushed
the
bengotow-2025-03/FE-798
branch
from
3e49d68 to
1f58153
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 9d8a845. |
| return 'Select one or more assets to materialize'; | ||
| } | ||
| if (all.some((a) => !a.hasMaterializePermission)) { | ||
| return 'You do not have permission to materialize assets'; |
There was a problem hiding this comment.
But you might be able to materialize some of them, no?
There was a problem hiding this comment.
Yeah I think that is true... It's possible this should behave like a mixed materializable / observable selection and say Materialize (2) instead of Materialize (4) when you are missing permissions on two of the assets. I'll ask Josh next time we talk to him, I'm not sure how common this case is!
| return 'Assets do not have observation functions'; | ||
| } | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Might be worth writing some simple jest specs for these.
There was a problem hiding this comment.
Yeah good call I'll put one together
bengotow
force-pushed
the
bengotow-2025-03/FE-798
branch
from
1f58153 to
9d8a845
Compare
Summary & Motivation
https://linear.app/dagster-labs/issue/FE-798/improve-tooltip-for-button-with-no-selection
Before:
After:
How I Tested These Changes
Other cases are unchanged, I just unwound a mega-ternary into a function (probably my doing...) and added a new case at the top. Verified the other cases still work by selecting non-executable and observable assets.