[ui] Restore __typename to tag filtering on automations #28806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b15e14a. |
salazarm
approved these changes
Mar 27, 2025
gibsondan
pushed a commit
that referenced
this pull request
Mar 27, 2025
## Summary & Motivation In automation tag filtering, we're depending on the `__typename` key/value pair that I discarded in #28583. Tag filtering is currently broken because of its removal. Revert that change. I think I missed this because the tag set that I was checking appeared to result in an expected empty set. ## How I Tested These Changes View automations with a tag filter, verify that it works correctly. Add multiple tags to filter, verify that this continues to work correctly. ## Changelog [ui] Fix tag filtering on automations list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
In automation tag filtering, we're depending on the
__typenamekey/value pair that I discarded in #28583. Tag filtering is currently broken because of its removal. Revert that change.I think I missed this because the tag set that I was checking appeared to result in an expected empty set.
How I Tested These Changes
View automations with a tag filter, verify that it works correctly. Add multiple tags to filter, verify that this continues to work correctly.
Changelog
[ui] Fix tag filtering on automations list.