-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add paginated partition key graphql fields to partitioned asset nodes #28774
base: prha/dynamic_store_connection
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
691d0a4
to
8194d38
Compare
56c1cbb
to
476a4af
Compare
8194d38
to
3479f85
Compare
1bb3cad
to
dccb5e4
Compare
3479f85
to
60ace3b
Compare
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit dd30b2e. |
9b77cc2
to
1d6f53d
Compare
3f91631
to
596cbbd
Compare
1d6f53d
to
9842748
Compare
596cbbd
to
6713344
Compare
63408e2
to
66476ee
Compare
6713344
to
4fdf2de
Compare
66476ee
to
075048f
Compare
if not self._dynamic_partitions_loader: | ||
check.failed("dynamic_partitions_loader must be provided to get partition keys") | ||
|
||
if not self._remote_node.is_partitioned: | ||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order of these checks should be swapped to improve error handling. First check if not self._remote_node.is_partitioned:
and return None
, then check for the dynamic partitions loader.
The current implementation will raise an error about missing dynamic_partitions_loader
even for non-partitioned assets, which is confusing since the loader isn't needed in that case. By checking partitioning first, you'll avoid unnecessary errors for non-partitioned assets.
if not self._dynamic_partitions_loader: | |
check.failed("dynamic_partitions_loader must be provided to get partition keys") | |
if not self._remote_node.is_partitioned: | |
return None | |
if not self._remote_node.is_partitioned: | |
return None | |
if not self._dynamic_partitions_loader: | |
check.failed("dynamic_partitions_loader must be provided to get partition keys") |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
075048f
to
ca6890c
Compare
4fdf2de
to
271b2d8
Compare
ca6890c
to
dd30b2e
Compare
271b2d8
to
5d46c06
Compare
Summary & Motivation
Add paginated partition materializations field on asset node graphql fields.
How I Tested These Changes
BK