[da] Update initial_evaluation condition to only detect partitions_def changes #28764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
OwenKephart
force-pushed
the
03-26-_da_update_initial_evaluation_condition_to_only_detect_partitions_def_changes
branch
from
0f24812 to
1bf7067
Compare
OwenKephart
force-pushed
the
03-26-_da_remove_assetselection_information_from_depscondition_checkscondition
branch
2 times, most recently
from
0f162e3 to
e15f221
Compare
OwenKephart
force-pushed
the
03-26-_da_update_initial_evaluation_condition_to_only_detect_partitions_def_changes
branch
2 times, most recently
from
9fb6c5f to
bcfbae2
Compare
OwenKephart
force-pushed
the
03-26-_da_remove_assetselection_information_from_depscondition_checkscondition
branch
from
e15f221 to
82a0ba9
Compare
OwenKephart
force-pushed
the
03-26-_da_update_initial_evaluation_condition_to_only_detect_partitions_def_changes
branch
2 times, most recently
from
1806c05 to
b1d71f3
Compare
OwenKephart
force-pushed
the
03-26-_da_remove_assetselection_information_from_depscondition_checkscondition
branch
from
82a0ba9 to
4bcd8ad
Compare
gibsondan
approved these changes
Mar 26, 2025
| condition_tree_id = context.root_context.condition.get_unique_id() | ||
| if context.previous_true_subset is None or condition_tree_id != context.cursor: | ||
| if self._is_initial_evaluation(context): |
There was a problem hiding this comment.
to sanity check - there is no risk of this firing incorrectly since we are making the rule strictly more permissive.
If you had previously changed just the parittions definition of the asset and nothing else, would this rule have fired? (i.e. would that have impacted the condition_tree_id)?
| @@ -68,11 +69,14 @@ def _result_iter(r): | |||
| return initial_evaluation_result.true_subset.size | |||
|
|
|||
|
|
|||
| def test_update_on_condition_change() -> None: | |||
| @pytest.mark.parametrize("pd_change", [True, False]) | |||
There was a problem hiding this comment.
nit this is a strange acronym choice :)
OwenKephart
changed the base branch from
03-26-_da_remove_assetselection_information_from_depscondition_checkscondition
to
graphite-base/28764
OwenKephart
force-pushed
the
03-26-_da_update_initial_evaluation_condition_to_only_detect_partitions_def_changes
branch
from
b1d71f3 to
e8d9cae
Compare
OwenKephart
deleted the
03-26-_da_update_initial_evaluation_condition_to_only_detect_partitions_def_changes
branch
gibsondan
pushed a commit
that referenced
this pull request
Mar 26, 2025
…f changes (#28764) ## Summary & Motivation This is actually more aligned with the purpose of this condition, as you could imagine having an unpartitioned asset with `AutomationCondition.eager()` being turned into a static-partitioned asset with 100s of partitions and experiencing the bad behavior of all partitions updating. It's also more accurate that this is the "initial_evaluation" of those partitions in this case. ## How I Tested These Changes ## Changelog The `AutomationCondition.initial_evaluation` condition has been updated to become true for all partitions of an asset whenever the PartitionsDefinition of that asset changes, rather than whenever the structure of the condition changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This is actually more aligned with the purpose of this condition, as you could imagine having an unpartitioned asset with
AutomationCondition.eager()being turned into a static-partitioned asset with 100s of partitions and experiencing the bad behavior of all partitions updating.It's also more accurate that this is the "initial_evaluation" of those partitions in this case.
How I Tested These Changes
Changelog
The
AutomationCondition.initial_evaluationcondition has been updated to become true for all partitions of an asset whenever the PartitionsDefinition of that asset changes, rather than whenever the structure of the condition changes.