fix passing null value to preg_split (#507)

dachcom-digital · Jan 31, 2025 · 846e303 · 846e303
1 parent 8dd3e6d
commit 846e303
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -7,6 +7,7 @@
 - **[IMPROVEMENT]** Doctrine ORM 3.0 Support [#503](https://github.com/dachcom-digital/pimcore-formbuilder/pull/503)
 - **[BUGFIX]** API Channel: Keep array index when merging child nodes [@simon-matt-oetztal](https://github.com/dachcom-digital/pimcore-formbuilder/pull/496)
 - **[BUGFIX]** Update Custom Channel Documentation [#493](https://github.com/dachcom-digital/pimcore-formbuilder/issues/493)
+- **[BUGFIX]** Fix passing null value to `preg_split` 
 
 ## 5.1.4
 - **[BUGFIX]** Allow using double-opt-in variables in placeholder processor

diff --git a/src/OutputWorkflow/Channel/Email/Parser/MailParser.php b/src/OutputWorkflow/Channel/Email/Parser/MailParser.php
@@ -227,8 +227,8 @@ protected function extractPlaceHolder(string $str, array $fieldValues): mixed
             $str = str_replace($matches[0][$key], $value, $str);
         }
 
-        //remove invalid commas
-        $fragments = preg_split('@,@', $str, null, PREG_SPLIT_NO_EMPTY);
+        // remove invalid commas
+        $fragments = preg_split('@,@', $str, -1, PREG_SPLIT_NO_EMPTY);
         $fragmentsGlued = is_array($fragments) ? implode(',', $fragments) : $fragments;
         $extractedValue = is_string($fragmentsGlued) ? trim($fragmentsGlued) : $fragmentsGlued;