Skip to content

Commit

Permalink
updating syntax for aws marketplace
Browse files Browse the repository at this point in the history
  • Loading branch information
jerowe committed Mar 8, 2022
1 parent 4fcfaf9 commit 6b71a48
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion charts/shinyproxy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ dependencies:
tags:
- bitnami-common
version: 1.x.x
version: 0.10.7
version: 0.10.8
14 changes: 7 additions & 7 deletions charts/shinyproxy/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,19 @@ spec:
- name: http
containerPort: {{ .Values.containerPorts.http }}
env:
{{- if not .Values.authExistingSecretEnabled -}}
{{- if .Values.authExistingSecretEnabled }}
- name: SPRING_APPLICATION_JSON
valueFrom:
secretKeyRef:
name: {{ include "common.names.fullname" . }}
key: secrets.json
{{ else }}
name: {{ .Values.authExistingSecret.secretKeyRef.name }}
key: {{ .Values.authExistingSecret.secretKeyRef.key }}
{{- else }}
- name: SPRING_APPLICATION_JSON
valueFrom:
secretKeyRef:
name: {{ .Values.authExistingSecret.secretRef.name }}
key: {{ .Values.authExistingSecret.secretRef.key }}
{{ end }}
name: {{ include "common.names.fullname" . }}
key: secrets.json
{{- end }}
volumeMounts:
- name: application-conf
mountPath: /opt/shinyproxy/application.yml
Expand Down
4 changes: 2 additions & 2 deletions tests/shinyproxy/test_shinyproxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ def test_auth_existing_secret():
values_file = os.path.join(os.path.dirname(__file__), "values-auth-existing-secret.yaml")
chart = HelmChart(chart_name=chart_name, helm_dir=helm_dir, values_file=values_file)
chart.run_helm_template(files=["deployment.yaml"])
secret_name = chart.values_data['authExistingSecret']['secretRef']['name']
secret_key = chart.values_data['authExistingSecret']['secretRef']['key']
secret_name = chart.values_data['authExistingSecret']['secretKeyRef']['name']
secret_key = chart.values_data['authExistingSecret']['secretKeyRef']['key']

deployment_data = chart.rendered_data["deployment.yaml"]
container_env = deployment_data['spec']['template']['spec']['containers'][0]['env']
Expand Down
2 changes: 1 addition & 1 deletion tests/shinyproxy/values-auth-existing-secret.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
authExistingSecretEnabled: true
authExistingSecret:
secretRef:
secretKeyRef:
name: "my-shinyproxy-auth-secret"
key: "super-secrets.json"

0 comments on commit 6b71a48

Please sign in to comment.